| broulik | |
| ngraham |
| Dolphin |
CCBUG: 386379
after recent highdpi patches on scrolling that delegated it
completely to the scrollbar, based upon the scrollbar singleStep
setted to the tallest of the items in the view.
tough this makes scrolling way too fast, and on folders where just
few filenames are longer than most we can get a single scrolling
step almost double the number of lines configured in the
mouse kcm.
Using the shortest item instead of the tallest mitigates this problem
making it a bit more usable
tested on different folders in different view modes both with
mouse and touchpad
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
On my desktop it seems to improve it slightly but on my laptop I don't see any improvement, it's still way too fast. The slightest finger movement scrolls an entire page and more.
do you have in your qt copy this patch?
https://codereview.qt-project.org/#/c/212398/
Same results as Kai, but I also do not have that Qt patch. Still, this is a definite improvement for the wheel mouse use case.
Also FWIW we had trouble with hyper-sensitive touchpad scrolling in Gwenview a few months ago and fixed it with https://cgit.kde.org/gwenview.git/commit/?id=c4a84dad6292b9c7918bec8d7ed33114d3758730
I understand now. This patch does indeed make it better in the case where you have icons with really long/tall filenames, but it doesn't do anything to help the general case of Dolphin's scrolling being too fast everywhere at a basic level.
I think it can land, but it can't close 386379 since it doesn't completely solve the problem.
so, i would push and then try an approach similar to gwenview, tough seems a bit an hack (btw, that patch seems to have a completely different behavior on that cumulative delta reset on zoom in and zoom pout, is it intended?)
also, that gwenview patch really looks like a workaround for the Qt bug fixed by https://codereview.qt-project.org/#/c/212398/, since that's upstream now, i'm not sure is worth to workaround in random applications which would just harm in long term maintainability?