| hindenburg |
| Konsole |
This is to avoid the need to use the xprop hack to enable it.
It is disabled by default.
Also since the new blur method is landing (https://phabricator.kde.org/D9848) that is more efficient and much much higher quality than the current blur it will look really good.
FEATURE: 198175
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
In general, LGTM - have you tried this on Wayland?
Since it is disabled by default, we don't have to wait for kwin to be applied/released.
I very much like it!
I among others tried to fix this as can be seen in issue #198175 but gave up due to the wildly different corner cases that would make a small change really complicated.
Lets hope those that have a say in this like your approach :)
My machine does not support Wayland, so I can't test it.
Could anyone else please test this?
I don't quite understand what the problem is with the blur here or the issue about blurring different regions of the window: https://bugs.kde.org/show_bug.cgi?id=198175
| src/MainWindow.cpp | ||
|---|---|---|
| 886 | That can go i think ;) | |
I'm getting crashes on start up with latest patch
src/MainWindow.cpp:884:30: runtime error: member call on null pointer of type 'Konsole::SessionController'
I can't reproduce the problem.
Tried with kdesrc-build and with KDevelop too
What's your environment?
How do you build and run Konsole?
Where did you get this message?
My asan build generates it on startup:
/home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/MainWindow.cpp:884:30: runtime error: member call on null pointer of type 'Konsole::SessionController'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/MainWindow.cpp:884:30 in
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = konsole path = /usr/local/bin pid = 4609
I haven't research it further yet
cmake-options -DKONSOLE_BUILD_FONTEMBEDDER=TRUE -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_CXX_COMPILER=clang++ -DECM_ENABLE_SANITIZERS='address;leak;undefined'
The next "logical step" would be to implement the corner case that when someone has split view enabled with one side with a profile that has blur enabled and the other side(s) without blur.
We would need to update how XCB blurs, and I think that would be too big of a change.
Also I personally think that blurring the whole window is a better choice than blurring only parts of it, since this patch is for Konsole standalone only.
@hindenburg could you test it again please?
I don't find any obvious issues testing w/ Wayland or FreeBSD or my other setups. I haven't applied the "new blur" patch but as I understand that patch will just make the blur better looking.