Fix Build with Purpose
AbandonedPublic

Authored by tcanabrava on Jan 21 2018, 11:37 AM.

Details

Reviewers
apol
Group Reviewers
Okular
Summary

Purpose is not experimental anymore, we should find the
correct library then.

Diff Detail

Repository
R223 Okular
Branch
fixBuildWithPurpose
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava created this revision.Jan 21 2018, 11:37 AM
Restricted Application added a project: Okular. · View Herald TranscriptJan 21 2018, 11:37 AM
Restricted Application added a subscriber: Okular. · View Herald Transcript
tcanabrava requested review of this revision.Jan 21 2018, 11:37 AM

As long as okular does not depend on kf5.42, please keep the compatibility with the old library as others did

  • Handles Purpose on KF5 or KDEExperimental
aacid added a reviewer: apol.Jan 21 2018, 6:36 PM
aacid added a subscriber: aacid.

Let's see if Aleix agrees with that or he has a different idea on how to fix this mess. Because the stable version of Okular has the same problem and we can't obviously change the dependencies there.

As mentioned in https://bugs.kde.org/show_bug.cgi?id=389224#c2 , there is the following new commit for Purpose that should fix the build when the "old" name is used for the dependency: https://cgit.kde.org/purpose.git/commit/?id=20a304236100b29014403a894cbda2d93ab28e41

apol added a comment.Jan 22 2018, 12:58 AM

I changed it so KDEExperimental still works with newer Purpose. I'd say let's keep the old one and when it's released again, then just change to just KF5::Purpose.

with current git-master purpose compilled and running I still fail to compile Okular:

CMake Warning at /home/tcanabrava/Projects/install/lib64/cmake/KDEExperimentalPurpose/KDEExperimentalPurposeConfig.cmake:2 (message):

Look up the Purpose framework using KF5Purpose

Call Stack (most recent call first):

CMakeLists.txt:71 (find_package)

CMake Error at /home/tcanabrava/Projects/install/lib64/cmake/KDEExperimentalPurpose/KDEExperimentalPurposeConfig.cmake:5 (string):

string no output variable specified

Call Stack (most recent call first):

CMakeLists.txt:71 (find_package)
apol requested changes to this revision.Jan 28 2018, 2:23 PM

Shouldn't be needed anymore.

This revision now requires changes to proceed.Jan 28 2018, 2:23 PM
tcanabrava abandoned this revision.Feb 2 2018, 9:04 AM