I don't see a reason why rich text should be limited to API24+? Yes, the fromHtml(String source, int flags) method is API 24+ but for APIs lower than that you can use fromHtml(String source) as for example wrapped in androidx.core.text.HtmlCompat:

/**
    * Invokes {@link Html#fromHtml(String, int)} on API 24 and newer, otherwise {@code flags} are
    * ignored and {@link Html#fromHtml(String)} is used.
    */
@NonNull
public static Spanned fromHtml(@NonNull String source, @FromHtmlFlags int flags) {
    if (Build.VERSION.SDK_INT >= 24) {
        return Html.fromHtml(source, flags);
    }
    //noinspection deprecation
    return Html.fromHtml(source);
}

Quick other question: This repo doesn't contain a .arcconfig file yet, should I submit a patch to add it?

• const auto

• extract m_data->outputs() into a variable

• const function, std::all_of

Did you like the format? Anything we can improve upon?

Do we have such icons somewhere?

@svuorela No I don't have push access

Merged by Carl Schwan 3 days ago

No I don't have commit rights.
Luca Weiss luca@z3ntu.xyz (but isn't this information already as commit author?)

Change commit message

Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.

• empty states
• i18n
• Revert "i18n"

On Mobile, if the power button is pressed for short time, suspend to Ram as requested by Bhushan.

• Adjust empty state style and text
• Use i18n instead of qsTr

Taking screenshots with a key combo is also important, e.g. vol down & power for a few seconds like it's done in Android

No, I don't have any rights here.

I'm guessing the changed English strings will trigger a "untranslated string" warning in the translation software, so the translators should notice it, right?

Don't change the translated strings

Funnily enough Ctrl+Shift+0 is Ctrl+= on the German keyboard which is set by default to "Enlarge Font"

What about Ctrl+0? Web browsers use it and doesn't seem used in Konsole/shells yet.

No (this is one of my first patches 😄)

Presumably this means it'll break on < Firefox 58?

• Add m_fetchsqlite_fav to teardown

Do the same change as in D10605

@mlaurent Updated the patch.

Put slash directly into the QStringLiteral

Two more notes:

I researched a bit more. The commit af0a29a185f190088af4a3a9d0d5bfb28a8feae3 caused this behaviour. A small test app results in:

This patch works for me :)

quick question (in inline comment)

uhm I think I have to write a comment here to "submit" my inline comments?

Add the bug keyword

Well as we don't add failed mounts to the failList (if they fail because of 13 / MNT3ERR_ACCES) so the line if (failList.size() == exportsCount) { won't work then.