Fixes the problem described in https://bugs.kde.org/show_bug.cgi?id=375249
Unfortunately breaks the lines "// All exports failed to mount, fail" in
the current form.
BUG: 375249
Details
Details
- Reviewers
dfaure davidedmundson - Group Reviewers
Frameworks
Create an NFS share with at least one share that's restricted to an IP address other than yours.
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Thanks for the patch! Instead of a bugzilla link, you can just use a special keyword: "BUG: 375249"
This will ensure that the bug gets closed once the patch is accepted and merged.
What does this mean?
"Unfortunately breaks the lines "// All exports failed to mount, fail" in the current form."
Comment Actions
Well as we don't add failed mounts to the failList (if they fail because of 13 / MNT3ERR_ACCES) so the line if (failList.size() == exportsCount) { won't work then.
Will add the bug keyword. Didn't know BugZilla and Phabricator were connected :)
Comment Actions
As mentioned on IRC, this is a starting point but maybe the logic should be changed so that there is no error on connection is at least a mount point is accessible; the error should be on access.
PS: changes to the commit message in the git patch are not reflected in the review, you should edit it from the web interface.