Fix location of Firefox dbCacheFile

Authored by z3ntu on Feb 17 2018, 2:33 PM.



Before: ~/.cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite
After: ~/.cache/krunner/bookmarkrunnerfirefoxdbfile.sqlite

My guess is that the slash got lost while porting from KDE4.

Test Plan

KRunner creates the new file and uses it.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
z3ntu created this revision.Feb 17 2018, 2:33 PM
Restricted Application added a project: Plasma. Β· View Herald TranscriptFeb 17 2018, 2:33 PM
Restricted Application added a subscriber: plasma-devel. Β· View Herald Transcript
z3ntu requested review of this revision.Feb 17 2018, 2:33 PM
z3ntu added a comment.Feb 17 2018, 2:48 PM

I researched a bit more. The commit af0a29a185f190088af4a3a9d0d5bfb28a8feae3 caused this behaviour. A small test app results in:

Before: "/home/luca/.cache/bookmarkrunnerfirefoxdbfile.sqlite"
After : "/home/luca/.cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite"

so it isn't exactly going back to the old behaviour but putting it in ~/.cache/krunner/ makes more sense as other krunner files are there too.

mlaurent requested changes to this revision.Feb 17 2018, 5:02 PM
mlaurent added a subscriber: mlaurent.

Otherwise patch is correct.


or QStringLiteral("/bookmarkrunnerfirefoxdbfile.sqlite"); directly.

This revision now requires changes to proceed.Feb 17 2018, 5:02 PM
z3ntu updated this revision to Diff 27414.Feb 17 2018, 5:04 PM

Put slash directly into the QStringLiteral

z3ntu marked an inline comment as done.Feb 17 2018, 5:05 PM

@mlaurent Updated the patch.

mlaurent accepted this revision.Feb 17 2018, 5:21 PM


This revision is now accepted and ready to land.Feb 17 2018, 5:21 PM

Do you have commit access ?

No (this is one of my first patches πŸ˜„)

Ok I will commit for you.

This revision was automatically updated to reflect the committed changes.