petermajchrak (Peter Majchrak)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 20 2017, 6:31 PM (339 w, 6 d)
Availability
Available

Recent Activity

Aug 22 2018

petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

@ngraham I have in the meantime switched away from KDE, so it would be difficult for me to continue the development...

Aug 22 2018, 11:40 PM · Frameworks

Dec 27 2017

petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

Is there a way to separate this class to its own file? Or is it some convention in this project to have these huge files?

Dec 27 2017, 8:01 PM · Frameworks
petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Dec 27 2017, 7:57 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

Won't using the blocking versions block the UI as well?... that's why I chose to use the non blocking versions and just update the UI once the work is finished by the other threads.

Dec 27 2017, 7:07 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Screen out the cached algorithms beforehand

Dec 27 2017, 7:05 PM · Frameworks
petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Dec 27 2017, 6:30 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Fix mutex placement and add show cached checksum values when combobox value is changed

Dec 27 2017, 6:30 PM · Frameworks
petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Dec 27 2017, 6:11 PM · Frameworks
petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Dec 27 2017, 10:04 AM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Capture item path by value

Dec 27 2017, 9:58 AM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Format algorithm values in combobox.

Dec 27 2017, 8:14 AM · Frameworks

Dec 26 2017

petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Dec 26 2017, 7:34 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Reverted back to the combobox based layout

Dec 26 2017, 7:32 PM · Frameworks

Dec 21 2017

petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

Ou, ok. Sorry, I didn't know that. Perfect, so combobox it is then.

Dec 21 2017, 4:11 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I can revert it back to the combobox based layout. Don't we have some UX people that could take a look at this?

Dec 21 2017, 7:02 AM · Frameworks

Dec 20 2017

petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

@anthonyfieroni, @elvisangelaccio, @colomar any progress? just want to get a status... this diff seems to be taking quite a long time to get reviewed after making changes...

Dec 20 2017, 6:40 PM · Frameworks

Dec 11 2017

petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Small code tweaks, nothing that changes functionality

Dec 11 2017, 8:31 PM · Frameworks

Nov 26 2017

petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Nov 26 2017, 2:26 PM · Frameworks
petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Nov 26 2017, 1:42 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

I reverted back to the group box layout and parallelized hash calculations (removed the annoying recursive function).

Nov 26 2017, 1:39 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I am still not clear on what to do now. Should I revert it to be a lot of separate buttons (hidden in a collapsible group box) (as @elvisangelaccio said) or should I keep it in a dropdown (ok according to me and @anthonyfieroni)?... I'm going to fix some other stuff in the meantime. I also made this verifyChecksumRecursive function to verify the checksums serially (one after another)(because up to 2 algorithms can be candidates for certain checksum inputs) to not consume too much resources. I'm thinking of doing that in parallel instead. Do you think it's a good idea? Are there any guidelines for these situations?

Nov 26 2017, 12:11 PM · Frameworks

Oct 29 2017

petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 29 2017, 8:47 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Convert to only combobox based layout

Oct 29 2017, 8:46 PM · Frameworks

Oct 28 2017

petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I will also need help figuring out what config to use for storing the users last used hash algorithm from the combobox (if we go that route).

Oct 28 2017, 8:59 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

A possible combobox layout

Oct 28 2017, 8:57 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

KIO repository

Oct 28 2017, 8:19 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

It is kinda questionable as far as what are the most common hash algorithms. I most often use SHA512 for example. I think having only the combobox would be ok for me, but I'm not a UX person. So just let me know if you figure out anything else.

Oct 28 2017, 4:57 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I'm going to give that a try.

Oct 28 2017, 4:40 PM · Frameworks
petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 4:22 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Place advanced algorithms into KCollapsibleGroupBox

Oct 28 2017, 3:57 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I am new to KDE development and I want to use the KCollapsibleGroupBox but I don't know how. Are there any plugins for Qt Designer for KWidgetsAddons?

Oct 28 2017, 2:42 PM · Frameworks
petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 2:40 PM · Frameworks
petermajchrak added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I agree that the layout is not optimal. I'm going to try to optimize it now.

Oct 28 2017, 2:21 PM · Frameworks
petermajchrak updated the diff for D8536: Add more hashing algorithms to KPropertiesDialog.

Remove C++17 features

Oct 28 2017, 10:53 AM · Frameworks
petermajchrak added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 10:39 AM · Frameworks
petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 10:32 AM · Frameworks
petermajchrak updated the summary of D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 10:04 AM · Frameworks
petermajchrak created D8536: Add more hashing algorithms to KPropertiesDialog.
Oct 28 2017, 10:04 AM · Frameworks