Allow disabling KPackage install while building Breeze
AbandonedPublic

Authored by ntninja on Nov 22 2018, 10:39 PM.

Details

Summary

Truth to be told, I'm not 100% sure what this step actually does, but breeze seems to load just fine without this. Please tell me if I'm doing something terrible here.

Test Plan

Build with and without -DWITH_KPACKAGE_INSTALL=off and verify that both versions work.

Diff Detail

Repository
R31 Breeze
Lint
Lint Skipped
Unit
Unit Tests Skipped
ntninja created this revision.Nov 22 2018, 10:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 22 2018, 10:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ntninja requested review of this revision.Nov 22 2018, 10:39 PM
mart added a comment.Nov 23 2018, 10:57 AM

-1 for disabling random things, we would get reports of people not finding the breeze dark look and not knowing why, and if a distro would do this, would be even worse

ntninja abandoned this revision.Nov 23 2018, 11:02 AM

Thanks for the feedback, I've looked some more into what the KPackage does and I agree that it doesn't make sense to disable it in general. Closing this.