I tested again the value forward from Capture tab to Mount Tab,
it works as you said.

Le 01/02/2019 à 18:02, Wolfgang Reissenberger a écrit :

View Revision https://phabricator.kde.org/D18235
wreissenberger added a comment.

In D18235#403245 <https://phabricator.kde.org/D18235#403245>,
@alainz <https://phabricator.kde.org/p/alainz/> wrote:

Selecting checkbox in the Capture tab alone is not sufficient, the
Mount Tab checkbox must be selected too, Right?

At the end, the values on the Mount tab count. But when you start an
imaging session from the Capture tab, the values from the Capture tab
are forwarded to the Mount tab and overwrite the settings there.

I see!

The fact that we have two places whith meridian cflip checkbox and
setpoint is a bit confusing to me and will probably raise many
questions by other users later on, but this is a cosmetic thing,
the code works!

Agreed. I would prefer shifting it from the Capture tab to the
Scheduler tab, since the Scheduler contains data of other tabs as
well. But I do not want to make the steps too big.

I did not see the meridian flip beeing forwarded from capture to
mount tab, I still had one value in capture tab and another in
mount tab, and the value in mount tab is the one that triggered
the flip. Is my interpretation correct?

The value from the Capture tab is not forwarded immediately when
changing the values on the Capture tab but they change, when you press
the "Start" button on the Capture tab.

This was what I expected but id doesn't happen, I have to test again!

In D18235#403130, @alainz wrote:

In D18235#403062, @wreissenberger wrote:

In D18235#403009, @alainz wrote:

I just checked the changes and confirm it is running as expected (tests 1 to 4)

Great, many thanks!

I noticed that the capture.ui still contains "Meridian Flip if HA" input field and interfers with the field in the mount tab when capture sequence is started.

That's left there intentionally so that imaging sequences can hold meridian flip parameters. As soon as an imaging sequence is started, its meridian flip setup is forwarded to the Mount tab.

I will do more intensive testing,, I would like to make sure each test is reproducible.
Will come back to you in any case.

This change is not anymore required since D18235 solves my issue in a much better way.
Thanks to anybody working on this topic

In D18235#403062, @wreissenberger wrote:

In D18235#403009, @alainz wrote:

I just checked the changes and confirm it is running as expected (tests 1 to 4)

Great, many thanks!

I noticed that the capture.ui still contains "Meridian Flip if HA" input field and interfers with the field in the mount tab when capture sequence is started.

That's left there intentionally so that imaging sequences can hold meridian flip parameters. As soon as an imaging sequence is started, its meridian flip setup is forwarded to the Mount tab.

Le 01/02/2019 à 08:01, Jasem Mutlaq a écrit :

View Revision https://phabricator.kde.org/D18627
mutlaqja added a comment.

Thanks, but we cannot add any more options to the capture module UI.
It has to be added to opsekos.ui under the "Capture" tab. How does
this work with D18235 https://phabricator.kde.org/D18235? Maybe it
should be merged in there as well?

*REPOSITORY*
R321 KStars

*REVISION DETAIL*
https://phabricator.kde.org/D18627

*To: *alainz, KStars
*Cc: *mutlaqja, kde-edu, KStars, smoe, narvaez, apol

View Revision https://phabricator.kde.org/D18235
wreissenberger edited the summary of this revision. (Show Details)
https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-vg656fdldlbpink/

*CHANGES TO REVISION SUMMARY*
...
If capturing is not running, the meridian flip is started immediately.
...

In D18235#402892 https://phabricator.kde.org/D18235#402892,
@TallFurryMan https://phabricator.kde.org/p/TallFurryMan/ wrote:

D18627 <https://phabricator.kde.org/D18627> requires attention. Is
it compatible/complementary/unnecessary with this diff?

Hm, I did not implement a timeout at all, a slew may take as long as
it takes. Do we really need such a timeout that checks, whether the
meridian flip slew has completed?

Therefore, my implementation makes this change D18627
https://phabricator.kde.org/D18627 obsolete. On the other hand, it
depends, how long we need to get the new implementation mature enough
for distribution.

I believe yes, this change makes it non necessary. No Timeout, no need
to adjust it :-)

See attached UI screen shot