Made meridian flip Time Out a parameter to allow user to change this value
AbandonedPublic

Authored by alainz on Jan 31 2019, 2:40 PM.

Details

Reviewers
None
Group Reviewers
KStars
Summary
  • Ekos meridian flip default time out is 90 seconds
  • This is not enough for some mounts
  • Changed this constant to a parameter
Test Plan

Diff Detail

Repository
R321 KStars
Lint
Lint Skipped
Unit
Unit Tests Skipped
alainz created this revision.Jan 31 2019, 2:40 PM
alainz created this object with edit policy "No One".
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 31 2019, 2:40 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
alainz requested review of this revision.Jan 31 2019, 2:40 PM

See attached UI screen shot

Thanks, but we cannot add any more options to the capture module UI. It has to be added to opsekos.ui under the "Capture" tab. How does this work with D18235? Maybe it should be merged in there as well?

alainz added a comment.Feb 1 2019, 9:15 AM

Le 01/02/2019 à 08:01, Jasem Mutlaq a écrit :

View Revision https://phabricator.kde.org/D18627
mutlaqja added a comment.

Thanks, but we cannot add any more options to the capture module UI.
It has to be added to opsekos.ui under the "Capture" tab. How does
this work with D18235 https://phabricator.kde.org/D18235? Maybe it
should be merged in there as well?

*REPOSITORY*
R321 KStars

*REVISION DETAIL*
https://phabricator.kde.org/D18627

*To: *alainz, KStars
*Cc: *mutlaqja, kde-edu, KStars, smoe, narvaez, apol

It is alright with D18235, I tested it yesterday night and so far
dicovered no issue, it solves my issue in a much better way.

Do I have to close D18627? or do you do it.

I am new to this platform so a bit usure haw to behave.

yurchor added a subscriber: yurchor.Feb 1 2019, 9:29 AM

It is alright with D18235, I tested it yesterday night and so far
dicovered no issue, it solves my issue in a much better way.

Do I have to close D18627? or do you do it.

I am new to this platform so a bit unsure how to behave.

Hi,

You can just abandon this differential revision (an option in the "Add Action..." list above the field for messages on the revision's page) and make a note that it can be replaced with D18235.

Hope this helps.

alainz abandoned this revision.Feb 1 2019, 9:35 AM

This change is not anymore required since D18235 solves my issue in a much better way.
Thanks to anybody working on this topic