Lekensteyn (Peter Wu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2016, 4:03 PM (393 w, 3 d)
Availability
Available

Recent Activity

Jun 2 2019

Lekensteyn committed R241:cb5a3ac8ff22: kioexec: change the scary debug messages for delayed deletion (authored by Lekensteyn).
kioexec: change the scary debug messages for delayed deletion
Jun 2 2019, 4:33 PM
Lekensteyn closed D21367: kioexec: change the scary debug messages for delayed deletion.
Jun 2 2019, 4:33 PM · Frameworks

May 27 2019

Lekensteyn updated the diff for D21367: kioexec: change the scary debug messages for delayed deletion.

Using camelCase now.

May 27 2019, 8:56 AM · Frameworks

May 25 2019

Lekensteyn updated the diff for D21367: kioexec: change the scary debug messages for delayed deletion.

Addressed review comment by adding a constant for the interval. Changed minutes -> seconds in the debug message.

May 25 2019, 12:00 PM · Frameworks

May 23 2019

Lekensteyn requested review of D21367: kioexec: change the scary debug messages for delayed deletion.
May 23 2019, 3:39 PM · Frameworks

Mar 3 2019

Lekensteyn committed R241:d8fcc1e8c62c: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog (authored by Lekensteyn).
Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog
Mar 3 2019, 7:58 PM
Lekensteyn closed D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.
Mar 3 2019, 7:58 PM · Frameworks
Lekensteyn updated the diff for D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.

@dfaure I've replaced the outdated comment, how does this version look?

Mar 3 2019, 3:49 PM · Frameworks

Feb 26 2019

Lekensteyn added a comment to D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.

Ping?

Feb 26 2019, 4:37 PM · Frameworks

Feb 15 2019

Lekensteyn updated the diff for D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.

Added context, I thought that it would be looked up by Phabricator once linked to a repo.

Feb 15 2019, 9:44 AM · Frameworks
Lekensteyn requested review of D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.
Feb 15 2019, 1:46 AM · Frameworks

Sep 12 2018

Lekensteyn committed R983:f13028bcb2c6: Fix regression in scroll handling (authored by Lekensteyn).
Fix regression in scroll handling
Sep 12 2018, 5:46 PM
Lekensteyn closed D15411: Fix regression in scroll handling.
Sep 12 2018, 5:46 PM

Sep 10 2018

Lekensteyn requested review of D15411: Fix regression in scroll handling.
Sep 10 2018, 4:51 PM

Aug 23 2018

Lekensteyn added a comment to D14904: TOC: Add collapse/expand options.

The style for the files you've touched is [mostly] braces on next line, not same line

Aug 23 2018, 5:51 PM · Okular
Lekensteyn added a comment to D14904: TOC: Add collapse/expand options.

The braces are all in the wrong place

Aug 23 2018, 10:41 AM · Okular
Lekensteyn updated the diff for D14904: TOC: Add collapse/expand options.

I changed the text and removed the icons as I was not able to find a suitable replacement in /usr/share/icons (no results for expand|collapse, "tree" did not have good candidates.)

Aug 23 2018, 10:35 AM · Okular

Aug 20 2018

Lekensteyn added a comment to D14904: TOC: Add collapse/expand options.

Hi Nathaniel, thank you for your feedback!

Aug 20 2018, 2:05 PM · Okular

Aug 17 2018

Lekensteyn requested review of D14904: TOC: Add collapse/expand options.
Aug 17 2018, 4:40 PM · Okular

Jan 23 2018

Lekensteyn added a comment to D10035: Sanitize alpha channel only if actually broken.

The code was added to fix a bug, https://bugs.kde.org/show_bug.cgi?id=362450

Jan 23 2018, 5:18 PM · Spectacle

Apr 26 2017

Lekensteyn added a comment to D4975: Prevent misdetection of EOF on Linux.

(FWIW, I ran a patched kpty 5.32.0-1 version for a while and didn't have the hang issue until I recently upgraded to an unpatched 5.33.0-1. Haven't had a moment so far to dig deeper into the issue though.)

Apr 26 2017, 8:41 PM · Frameworks

Mar 17 2017

Lekensteyn added a comment to D4975: Prevent misdetection of EOF on Linux.
In D4975#95754, @ossi wrote:

first try googling it; maybe there is even a response on stackoverflow (as so often happens).

Mar 17 2017, 10:50 PM · Frameworks
Lekensteyn added a comment to D4975: Prevent misdetection of EOF on Linux.
In D4975#95727, @ossi wrote:

please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path).

Mar 17 2017, 5:27 PM · Frameworks

Mar 8 2017

Lekensteyn created D4975: Prevent misdetection of EOF on Linux.
Mar 8 2017, 10:51 AM · Frameworks

Oct 20 2016

Lekensteyn committed R166:47e130192626: Show message if kipi-plugins are not installed (authored by Lekensteyn).
Show message if kipi-plugins are not installed
Oct 20 2016, 9:05 PM
Lekensteyn committed R166:a6911eb80af1: Lazy load export image, halving the startup time (authored by Lekensteyn).
Lazy load export image, halving the startup time
Oct 20 2016, 9:05 PM
Lekensteyn committed R166:a41e83edbaad: Fix blurry preview on HiDPI displays (authored by Lekensteyn).
Fix blurry preview on HiDPI displays
Oct 20 2016, 9:05 PM
Lekensteyn committed R166:124498088238: Fix initial region location for High DPI screens (authored by Lekensteyn).
Fix initial region location for High DPI screens
Oct 20 2016, 9:05 PM

Oct 14 2016

Lekensteyn committed R166:7a5603fda8f1: Refactor pixmap grabbing, add robustness (authored by Lekensteyn).
Refactor pixmap grabbing, add robustness
Oct 14 2016, 9:09 AM

Oct 13 2016

Lekensteyn committed R166:aab52c83ba70: Capture all windows for "Window under cursor" (authored by Lekensteyn).
Capture all windows for "Window under cursor"
Oct 13 2016, 12:13 AM

Oct 12 2016

Lekensteyn committed R166:e4c2e564a5b9: Replace KScreen by QScreen for current window grab (authored by Lekensteyn).
Replace KScreen by QScreen for current window grab
Oct 12 2016, 5:41 PM
Lekensteyn committed R166:c9de3b0d09a4: Use native file dialog for the Save As option (authored by Lekensteyn).
Use native file dialog for the Save As option
Oct 12 2016, 5:16 PM

Oct 11 2016

Lekensteyn committed R166:9bca22ef6689: Make the preview respect devicePixelScale (authored by Lekensteyn).
Make the preview respect devicePixelScale
Oct 11 2016, 9:04 PM
Lekensteyn committed R166:af7469148e15: Fix memleak of xcb_image_t (authored by Lekensteyn).
Fix memleak of xcb_image_t
Oct 11 2016, 9:04 PM
Lekensteyn committed R166:45751d7d8bc2: Fix broken previews for small selection (authored by Lekensteyn).
Fix broken previews for small selection
Oct 11 2016, 9:04 PM
Lekensteyn committed R166:45d3a0700aaa: Hide bottom help text when selection is overlapping (authored by Lekensteyn).
Hide bottom help text when selection is overlapping
Oct 11 2016, 9:04 PM
Lekensteyn committed R166:362cf1c7b5ec: Add selection size information (authored by Lekensteyn).
Add selection size information
Oct 11 2016, 9:04 PM