Kebianizao (Raúl Sánchez Siles)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 11 2018, 11:13 AM (87 w, 8 m)
Availability
Available

Recent Activity

Aug 16 2018

Kebianizao updated the summary of D14710: Inject default environment group variables into debug process environment..
Aug 16 2018, 11:50 AM · KDevelop
Kebianizao added a comment to D14870: Inject environment profile variables into debug process environment..

Thanks for the review.
To be honest I'm not sure how could I submit this patch. If you mean submitting to the mailing list, I can do, but I think it's already there, as phabricator is linked to kdevelop-devel. If you mean pushing to the repository, I'm not aware that I've been granted push permission.
Also, take into account that the patched is based on 5.2 branch as I run latest stable kdevelop (5.2.3), I haven't tested this on either kdev-python or kdevelop master branches.

Aug 16 2018, 11:43 AM · KDevelop

Aug 15 2018

Kebianizao updated the summary of D14870: Inject environment profile variables into debug process environment..
Aug 15 2018, 11:03 PM · KDevelop
Kebianizao added a comment to D14710: Inject default environment group variables into debug process environment..

This differential is (hopefully) superseded by https://phabricator.kde.org/D14870

Aug 15 2018, 11:01 PM · KDevelop
Kebianizao requested review of D14870: Inject environment profile variables into debug process environment..
Aug 15 2018, 11:00 PM · KDevelop
Kebianizao added a comment to D14710: Inject default environment group variables into debug process environment..

I'm actually fine with this approach, I just don't understand why the environment is set once on the process and once on the job. Why is this necessary, or do I misunderstand what it's doing ...?

Aug 15 2018, 10:42 PM · KDevelop
Kebianizao updated the diff for D14710: Inject default environment group variables into debug process environment..

Updated commit according to commenters feedback.
Keeping original approach, still improvable,

Aug 15 2018, 9:34 PM · KDevelop
Kebianizao added a comment to D14710: Inject default environment group variables into debug process environment..

Thanks for the patch!

Sorry, it has been years since I looked at the debugger code. Why do you need to set the environment twice, once on the job and once on the process? Otherwise, this looks fine.

Aug 15 2018, 8:58 PM · KDevelop
Kebianizao added a comment to D14710: Inject default environment group variables into debug process environment..

I'm updating the patch. I will send it as soon as I have it.

Aug 15 2018, 8:38 PM · KDevelop
Kebianizao added inline comments to D14710: Inject default environment group variables into debug process environment..
Aug 15 2018, 8:34 PM · KDevelop
Kebianizao added a comment to D14710: Inject default environment group variables into debug process environment..

Hi All:
Sorry for the delay. I've been AFK for some days and I afterwards I needed to resettle my development environment. I think I'm almost ready.
@apol Thanks a lot for revision. I'll answer your comments in a moment.
@vkorneev I'll answer your comment in a moments.
After I had the differential reviewed I noticed I had a slightly different version, where environment variables are injected at a different point. Unfortunately, I don't have access to that version so I can't provide it just now. If you want I may send it in two weeks (I know, it's quite a lot, don't ask) or we can proceed with a final solution in this differential.

Aug 15 2018, 8:19 PM · KDevelop

Aug 9 2018

Kebianizao updated the summary of D14710: Inject default environment group variables into debug process environment..
Aug 9 2018, 1:36 PM · KDevelop
Kebianizao requested review of D14710: Inject default environment group variables into debug process environment..
Aug 9 2018, 1:31 PM · KDevelop