- User Since
- Apr 11 2018, 11:13 AM (128 w, 2 d)
Aug 16 2018
Thanks for the review.
To be honest I'm not sure how could I submit this patch. If you mean submitting to the mailing list, I can do, but I think it's already there, as phabricator is linked to kdevelop-devel. If you mean pushing to the repository, I'm not aware that I've been granted push permission.
Also, take into account that the patched is based on 5.2 branch as I run latest stable kdevelop (5.2.3), I haven't tested this on either kdev-python or kdevelop master branches.
Aug 15 2018
This differential is (hopefully) superseded by https://phabricator.kde.org/D14870
Updated commit according to commenters feedback.
Keeping original approach, still improvable,
I'm updating the patch. I will send it as soon as I have it.
Sorry for the delay. I've been AFK for some days and I afterwards I needed to resettle my development environment. I think I'm almost ready.
@apol Thanks a lot for revision. I'll answer your comments in a moment.
@vkorneev I'll answer your comment in a moments.
After I had the differential reviewed I noticed I had a slightly different version, where environment variables are injected at a different point. Unfortunately, I don't have access to that version so I can't provide it just now. If you want I may send it in two weeks (I know, it's quite a lot, don't ask) or we can proceed with a final solution in this differential.