Thanks for the review.
To be honest I'm not sure how could I submit this patch. If you mean submitting to the mailing list, I can do, but I think it's already there, as phabricator is linked to kdevelop-devel. If you mean pushing to the repository, I'm not aware that I've been granted push permission.
Also, take into account that the patched is based on 5.2 branch as I run latest stable kdevelop (5.2.3), I haven't tested this on either kdev-python or kdevelop master branches.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Aug 16 2018
Aug 15 2018
This differential is (hopefully) superseded by https://phabricator.kde.org/D14870
In D14710#309820, @brauch wrote:I'm actually fine with this approach, I just don't understand why the environment is set once on the process and once on the job. Why is this necessary, or do I misunderstand what it's doing ...?
Updated commit according to commenters feedback.
Keeping original approach, still improvable,
In D14710#309769, @brauch wrote:Thanks for the patch!
Sorry, it has been years since I looked at the debugger code. Why do you need to set the environment twice, once on the job and once on the process? Otherwise, this looks fine.
I'm updating the patch. I will send it as soon as I have it.
Hi All:
Sorry for the delay. I've been AFK for some days and I afterwards I needed to resettle my development environment. I think I'm almost ready.
@apol Thanks a lot for revision. I'll answer your comments in a moment.
@vkorneev I'll answer your comment in a moments.
After I had the differential reviewed I noticed I had a slightly different version, where environment variables are injected at a different point. Unfortunately, I don't have access to that version so I can't provide it just now. If you want I may send it in two weeks (I know, it's quite a lot, don't ask) or we can proceed with a final solution in this differential.