Feed Advanced Search

Nov 23 2021

rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.

Recently I ran into a weird startup issue that ultimately I traced back to the use of std::unique_ptr and its underlying implementation. It's been a while, so I'm no longer fresh on the details. Basically, if an interrupt or exception occurs during the call to std::unique_ptr, a subsequent call will hang (or crash). From what I understood it's mostly an issue on non-x86_64 platforms, but it can happen there too (as I found out). There has been at least 1 attempt to fix the problem in the underlying system library (libstdc++, I think but possibly libc) but that one was reverted because it introduced other regressions, from what I understand.

Nov 23 2021, 5:40 PM · KF6

Oct 13 2021

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Well, that's what I get for trusting my memory, I didn't even realise at first that you'd been jumping on a PR that I started. :-/

Oct 13 2021, 10:19 AM · KDevelop

Oct 12 2021

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Could you please cancel that email and paste its contents in a Phabricator comment?

Oct 12 2021, 8:53 AM · KDevelop

Oct 11 2021

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Igor Kushnir wrote on 20211011::17:30:08 re: "D15532: [Astyle] Add Objective C to list of languages with formatters"

Oct 11 2021, 6:04 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Igor Kushnir wrote on 20211011::12:38:18 re: "D15532: [Astyle] Add Objective C to list of languages with formatters"

Oct 11 2021, 5:22 PM · KDevelop

May 15 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.

In addition:

  • I only see said button when using KWin
  • KWin allows me to configure which titlebar buttons I want to see (and where).
May 15 2021, 12:16 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Mar 16 2021

rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.
No need for a macro even: https://invent.kde.org/libraries/kpublictransport/-/blob/master/src/lib/pointer_helper_p.h#L14 - that gives you the backward compatibility with older Qt versions without conflicting with the newer ones.
Mar 16 2021, 5:57 PM · KF6
rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.
this instance here is just owned by this very class object,

>
> You mean to confirm to anyone who had forgotten what `private' means? 8-)

This is an orthogonal concept to private, I cannot follow what you mean here.

Mar 16 2021, 4:51 PM · KF6
rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.
The point is to use the expressiveness of this highlevel language feature to tell everyone: this instance here is just owned by this very class object,
Mar 16 2021, 3:59 PM · KF6
rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.

Ahmad Samir wrote on 20210316::13:50:33 re: "T13924: Unify how d-pointer is created in frameworks' classes"

Mar 16 2021, 2:41 PM · KF6
rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.
When we bump minimum versions we want to use the things they have, if we  take care to not break older versions there is no point in requiring newer versions
Mar 16 2021, 1:33 PM · KF6
rjvbb added a comment to T13924: Unify how d-pointer is created in frameworks' classes.

What's the point of using std::unique_ptr here? Isn't that inherent in the fact that the instance is private and (typically) allocated in the dtor?

Mar 16 2021, 12:42 PM · KF6

Mar 1 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.

That's a substantial list which includes applications with a steepish learning curve that probably provide useful information in the What's This texts.

Mar 1 2021, 9:06 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Feb 22 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.
I agree but I had to draw the line somewhere. I drew it at terms like file, folder, view. Otherwise I would have to paraphrase or explain them in every other text. The context help isn't that well suited for a very basic introduction.
Feb 22 2021, 8:41 AM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Feb 11 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.
  • It was incompletely implemented by developers, reducing the incentive to enter the mode that showed the balloons
Feb 11 2021, 11:21 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG
rjvbb added a comment to T9986: Delete "What's This" inline help functionality.

Felix Ernst wrote on 20210210::18:07:07 re: "T9986: Delete "What's This" inline help functionality"

Feb 11 2021, 1:27 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Feb 6 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.
Not really. This is just the same Whatsthis with a button in front.
Feb 6 2021, 10:16 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Feb 2 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.
In the Kate/KTextEditor config dialog we tried to provide a lot of "what's this" stuff.
But I guess it would make sense to move that there just to tooltips.
Feb 2 2021, 12:49 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG
rjvbb added a comment to T9986: Delete "What's This" inline help functionality.
Making it useful is not a practical option IMO since it requires implementing it for every UI control in every piece of software, which is not even feasible for our own software--let alone 3rd-party software. It's one of those things that has to be universal to be useful, and because we can't make it so, it never will be.
Feb 2 2021, 10:42 AM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Jan 23 2021

rjvbb added a comment to T9986: Delete "What's This" inline help functionality.

There have long been applications that provide a "what's this" menu item in the Help menu or equivalent. I think this is important functionality as it allows users to figure out what things do, it eases the burden on documentation writers to keep the manual up-to-date and complete (a big issue with much FOSS) and it also allows to minimise automatic tooltip clutter without giving up all hope of contextual guidance.

Jan 23 2021, 1:33 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Oct 6 2020

rjvbb added a comment to D21076: ICC Color Correction Effect.

You must be right about the greyscale effect; I don't see any actual calculation of the intensity (from the RGB values) in the code that gets installed. And that code is JavaScript (aka QtScript); up to you to determine if your effect could be implemented in that language...

Oct 6 2020, 6:50 PM · KWin
rjvbb added a comment to D21076: ICC Color Correction Effect.
Is it? How does it work? It definitely requires distribution of a binary addon. Does KDE installer build binary addons?
Oct 6 2020, 1:26 PM · KWin
rjvbb added a comment to D21076: ICC Color Correction Effect.

As I understand 3rdparty binary effects are harder to install, very unpopular and it will take 100 years to get it packaged in all distros...

Oct 6 2020, 9:50 AM · KWin

Oct 5 2020

rjvbb added a comment to D21076: ICC Color Correction Effect.

I was maybe a little quick. Consider these differences

Oct 5 2020, 1:10 PM · KWin
rjvbb accepted D21076: ICC Color Correction Effect.

Yup, works for me now.

Oct 5 2020, 12:58 PM · KWin
rjvbb added a comment to D21076: ICC Color Correction Effect.

Hm, and by not working you mean that the translucency effect gets canceled, but the correction itself works, right?

Oct 5 2020, 8:26 AM · KWin

Oct 4 2020

rjvbb added a comment to D21076: ICC Color Correction Effect.

Something has probably changed since 5.13.3, because translucency-while-moving works fine with my KWin 5.17.5...

Oct 4 2020, 3:32 PM · KWin

Oct 2 2020

rjvbb requested changes to D21076: ICC Color Correction Effect.
By the way, I've updated the patch for KDE 5.17 + fixed it to work with translucency effects correctly (I didn't use "modulation" in the previous version of the patch).
Oct 2 2020, 4:37 PM · KWin