Feed Advanced Search

Mar 19 2019

rempt added a comment to D19881: Fix Sequential Iterator assert on invalid rectangles.

Right. One other nitpick, otherwise it looks all very sane to me.

Mar 19 2019, 4:40 PM · Krita
rempt added a member for Krita: Stable bug fixes: jgupta.
Mar 19 2019, 1:24 PM
rempt added a member for Krita: Next Regressions: jgupta.
Mar 19 2019, 1:23 PM
rempt added a member for Krita: Abyss: jgupta.
Mar 19 2019, 1:23 PM
rempt added a member for Krita: Next Features: jgupta.
Mar 19 2019, 1:22 PM
rempt added inline comments to D19881: Fix Sequential Iterator assert on invalid rectangles.
Mar 19 2019, 12:38 PM · Krita
rempt committed R37:d457dd36e647: Add some documentation (authored by rempt).
Add some documentation
Mar 19 2019, 11:55 AM
rempt committed R37:83c8ed928242: Don't disable wintab -- we're trying to use Qt's wintab now (authored by rempt).
Don't disable wintab -- we're trying to use Qt's wintab now
Mar 19 2019, 11:51 AM
rempt committed R37:8382b5a6ee22: Add a KisAbstractResourceModel interface class (authored by rempt).
Add a KisAbstractResourceModel interface class
Mar 19 2019, 10:11 AM
rempt committed R37:286e0d60fc87: Fix broken sig/slot connections (authored by rempt).
Fix broken sig/slot connections
Mar 19 2019, 10:11 AM
rempt committed R37:b4c856310750: Fix SQL statements (authored by rempt).
Fix SQL statements
Mar 19 2019, 8:05 AM
rempt committed R37:17b98a8e0ffe: Add note (authored by rempt).
Add note
Mar 19 2019, 8:05 AM
rempt committed R37:7194d548bc1b: Implement some more of KoResourceServer (authored by rempt).
Implement some more of KoResourceServer
Mar 19 2019, 8:05 AM
rempt committed R37:9335a99139d2: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 19 2019, 7:04 AM

Mar 18 2019

rempt committed R37:ef217ccd9408: Remove debug output now build magically works again (authored by rempt).
Remove debug output now build magically works again
Mar 18 2019, 3:22 PM
rempt committed R37:54a1e8272f1b: Try to build sip again (authored by rempt).
Try to build sip again
Mar 18 2019, 2:56 PM
rempt committed R37:9c521e39885c: More debug output... (authored by rempt).
More debug output...
Mar 18 2019, 12:43 PM
rempt committed R37:838ad68c882f: Add more debug output... (authored by rempt).
Add more debug output...
Mar 18 2019, 12:08 PM
rempt committed R37:5268f29de4d4: Remove obsolete scripts (authored by rempt).
Remove obsolete scripts
Mar 18 2019, 12:08 PM
rempt committed R37:0af06671904c: Add more debugging to the build-image script... (authored by rempt).
Add more debugging to the build-image script...
Mar 18 2019, 11:05 AM
rempt committed R37:3532330eb8ec: Let's skip sip for now, to make sure it is the problem (authored by rempt).
Let's skip sip for now, to make sure it is the problem
Mar 18 2019, 10:34 AM
rempt committed R37:e66855a9153e: Try harder to find sip.so (authored by rempt).
Try harder to find sip.so
Mar 18 2019, 10:11 AM
rempt committed R37:d096a84aae89: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 18 2019, 10:01 AM
rempt committed R37:6533d7fb6797: Update the location of sip (authored by rempt).
Update the location of sip
Mar 18 2019, 9:28 AM

Mar 17 2019

rempt committed R37:9c233f651f55: Update Qt to 5.12.2 (authored by rempt).
Update Qt to 5.12.2
Mar 17 2019, 2:29 PM

Mar 16 2019

rempt committed R37:0492ac784308: Use Qt's tablet support on Windows (authored by rempt).
Use Qt's tablet support on Windows
Mar 16 2019, 10:36 AM

Mar 15 2019

rempt committed R37:3768a3ccb1ce: Another bit I forgot to push, besides, boolean logic is hard (authored by rempt).
Another bit I forgot to push, besides, boolean logic is hard
Mar 15 2019, 5:47 PM
rempt committed R37:ae53038a2f86: Fix build (authored by rempt).
Fix build
Mar 15 2019, 3:49 PM
rempt committed R37:eb0928dff766: Add an option to use Qt's Windows tablet support, instead of ours (authored by rempt).
Add an option to use Qt's Windows tablet support, instead of ours
Mar 15 2019, 3:38 PM
rempt committed R37:f4a4194125d4: Fix problems when loading Krita 4.1 files saved in non-utf-8 locales (authored by rempt).
Fix problems when loading Krita 4.1 files saved in non-utf-8 locales
Mar 15 2019, 9:10 AM

Mar 14 2019

rempt added a comment to D19726: Setup for android(arm) build.
Mar 14 2019, 9:57 AM · Krita
rempt committed R37:a346056c781d: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 14 2019, 9:40 AM
rempt committed R37:b04e5df49a06: Add apidox (authored by rempt).
Add apidox
Mar 14 2019, 9:40 AM

Mar 13 2019

rempt added a comment to D19726: Setup for android(arm) build.
Mar 13 2019, 3:06 PM · Krita
rempt added a comment to D19726: Setup for android(arm) build.

> CMakeLists.txt:4
> if (WIN32)
> ExternalProject_Add( ext_expat
> DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR}

Maintainability-wise, having the same thing twice isn't very practical. Maybe you can just pass to this one some android extra arguments?

Mar 13 2019, 3:00 PM · Krita

Mar 12 2019

rempt committed R37:380557465a3b: Add some info about executable, language and hidpi state (authored by rempt).
Add some info about executable, language and hidpi state
Mar 12 2019, 3:00 PM
rempt committed R37:54b49fca970f: Replace QModelIndex::internalPointer with QModelIndex::data (authored by rempt).
Replace QModelIndex::internalPointer with QModelIndex::data
Mar 12 2019, 8:46 AM
rempt committed R37:253bbff1f81e: Fix crash on closing Krita (authored by rempt).
Fix crash on closing Krita
Mar 12 2019, 8:46 AM
rempt committed R37:cda99d02f158: Try, try again to make Qt build on the binary builder (authored by rempt).
Try, try again to make Qt build on the binary builder
Mar 12 2019, 8:14 AM
rempt committed R37:613c517dc47b: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 12 2019, 7:22 AM

Mar 11 2019

rempt added a comment to D15585: Add openssl download and build step to krita.

Do you remember how you added Krita's plugins to the bundle you made?

Mar 11 2019, 4:07 PM · Krita
rempt committed R37:3bd761666cd9: Warning-- (authored by rempt).
Warning--
Mar 11 2019, 3:43 PM
rempt committed R37:f1437a8755d7: Disable QtMultimedia on Linux for now (authored by rempt).
Disable QtMultimedia on Linux for now
Mar 11 2019, 3:43 PM
rempt accepted D15585: Add openssl download and build step to krita.
Mar 11 2019, 3:38 PM · Krita
rempt requested changes to D18993: Refactor KoColorSet to Change Its Data Structure.

Mark as request changes so it's out of my queue

Mar 11 2019, 3:37 PM · Krita
rempt accepted D19601: Python code checks: highpass, script_starter, scriptdocker.
Mar 11 2019, 3:36 PM · Krita
rempt committed R37:810c2bd27810: Try to fix appimage deps build (authored by rempt).
Try to fix appimage deps build
Mar 11 2019, 2:43 PM
rempt accepted D19611: Fix loading wrong file format (progress bar + recent docs).
Mar 11 2019, 2:13 PM · Krita
rempt accepted D19592: Added Support For libheif in 3rdparty.
Mar 11 2019, 2:10 PM · Krita
rempt accepted D19593: Fix data loss after flattening the image from inside the group.
Mar 11 2019, 2:09 PM · Krita
rempt committed R1012:2a04d40b426a: Add section about common problems with Wacom's drivers (authored by rempt).
Add section about common problems with Wacom's drivers
Mar 11 2019, 2:05 PM
rempt committed R37:7056b4187ab7: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 11 2019, 1:29 PM
rempt committed R37:5e1ecc3dee79: Update notes (authored by rempt).
Update notes
Mar 11 2019, 1:29 PM
rempt committed R37:b82e5624d072: Use built-in qt-xcb (authored by rempt).
Use built-in qt-xcb
Mar 11 2019, 12:51 PM
rempt committed R37:3edf490493e0: BUG:405336 Do not assume that there's image in a paintop (authored by rempt).
BUG:405336 Do not assume that there's image in a paintop
Mar 11 2019, 10:35 AM

Mar 9 2019

rempt committed R37:e9b99ee5b751: Rename this test (authored by rempt).
Rename this test
Mar 9 2019, 8:09 PM

Mar 7 2019

rempt committed R37:58966573d82a: Notify the observers if a resource has been removed (authored by rempt).
Notify the observers if a resource has been removed
Mar 7 2019, 3:00 PM
rempt committed R37:716cdb2220a1: Fix crash on start-up -- the extra filter model is allowed to be 0 (authored by rempt).
Fix crash on start-up -- the extra filter model is allowed to be 0
Mar 7 2019, 3:00 PM
rempt committed R37:caf06284f4c6: Remove KoResourceServerBase (authored by rempt).
Remove KoResourceServerBase
Mar 7 2019, 3:00 PM
rempt committed R37:239cab6ebb73: Remove the removeResourceAndBlacklist method (authored by rempt).
Remove the removeResourceAndBlacklist method
Mar 7 2019, 2:38 PM
rempt committed R37:7cea0a33b307: Rename KisBrushServer to KisBrushServerProvider (authored by rempt).
Rename KisBrushServer to KisBrushServerProvider
Mar 7 2019, 2:38 PM
rempt committed R37:5dedb705475e: The KoResourceServer instances don't load the resources anymore (authored by rempt).
The KoResourceServer instances don't load the resources anymore
Mar 7 2019, 2:38 PM
rempt requested changes to D19593: Fix data loss after flattening the image from inside the group.

Okay... I hadn't considered that. Please go ahead?

Mar 7 2019, 2:27 PM · Krita
rempt committed R37:aa077d4d2111: Remove KoResourceServerSimpleConstruction (authored by rempt).
Remove KoResourceServerSimpleConstruction
Mar 7 2019, 2:17 PM
rempt committed R37:c4eb0e9f5b69: Remove the createResource(s) methods from KoResourceServer (authored by rempt).
Remove the createResource(s) methods from KoResourceServer
Mar 7 2019, 2:17 PM
rempt committed R37:a32cb09968c8: Add a 'save' parameter to KisResourceModel::addResource (authored by rempt).
Add a 'save' parameter to KisResourceModel::addResource
Mar 7 2019, 2:17 PM
rempt committed R37:8cd783b31dd2: Add a Memory Storage type (authored by rempt).
Add a Memory Storage type
Mar 7 2019, 2:17 PM
rempt committed R37:88c4e34457a2: Add comments (authored by rempt).
Add comments
Mar 7 2019, 2:17 PM
rempt committed R37:585033e6ceca: Update notes (authored by rempt).
Update notes
Mar 7 2019, 2:16 PM
rempt committed R37:b4905a5eae6a: Remove KoResourceTagStore (authored by rempt).
Remove KoResourceTagStore
Mar 7 2019, 2:16 PM
rempt committed R37:8e29cba4faed: Remove unused class KoResourceFiltering (authored by rempt).
Remove unused class KoResourceFiltering
Mar 7 2019, 2:16 PM
rempt added a comment to D19592: Added Support For libheif in 3rdparty.

The history seems to suggest it was mean for Windows, though maybe not for mingw...

Mar 7 2019, 2:09 PM · Krita
rempt added a comment to D19592: Added Support For libheif in 3rdparty.

They do now? Last time I checked, they didn't. Yes, in that case, the configure step should be done with CMake.

Mar 7 2019, 2:05 PM · Krita
rempt accepted D19593: Fix data loss after flattening the image from inside the group.

I built and tested it, and yes, it fixes the issue.

Mar 7 2019, 2:04 PM · Krita
rempt added inline comments to D19592: Added Support For libheif in 3rdparty.
Mar 7 2019, 1:56 PM · Krita
rempt committed R37:0302c8779450: Remove extension and blacklisted files from KisResourceServer (authored by rempt).
Remove extension and blacklisted files from KisResourceServer
Mar 7 2019, 10:50 AM
rempt committed R37:9206e9d2d12e: Remove the inFront parameter for KoResourceServerProvider::addResource (authored by rempt).
Remove the inFront parameter for KoResourceServerProvider::addResource
Mar 7 2019, 10:21 AM
rempt committed R37:69945241b0c5: Remove the BundleServerProvider (authored by rempt).
Remove the BundleServerProvider
Mar 7 2019, 10:21 AM
rempt committed R37:35ce9010b538: Remove the KoResourceServer::loadResources method (authored by rempt).
Remove the KoResourceServer::loadResources method
Mar 7 2019, 10:21 AM
rempt committed R37:67de77cfafd9: Remove unused class KoResourceServerPolicies (authored by rempt).
Remove unused class KoResourceServerPolicies
Mar 7 2019, 10:21 AM
rempt committed R37:5a6452f290a2: Remove KoResourceServerAdapter (authored by rempt).
Remove KoResourceServerAdapter
Mar 7 2019, 9:51 AM
rempt committed R37:9c3592e82dac: Remove the palettemodel from libqml (authored by rempt).
Remove the palettemodel from libqml
Mar 7 2019, 9:51 AM
rempt committed R37:8642fa9180cb: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 7 2019, 7:55 AM
rempt committed R37:7ec9bb6e5d3b: Port away from KoResourceServerAdapter (authored by rempt).
Port away from KoResourceServerAdapter
Mar 7 2019, 7:55 AM
rempt committed R37:11cbe7627f66: Port the gradientmap widget away from the resource server (authored by rempt).
Port the gradientmap widget away from the resource server
Mar 7 2019, 7:55 AM
rempt committed R37:482825caa308: Port KoResourcePopupAction away from the resourceserver adapter (authored by rempt).
Port KoResourcePopupAction away from the resourceserver adapter
Mar 7 2019, 7:55 AM

Mar 6 2019

rempt committed R37:77d6cd8edd11: Remove the resource blacklist cleanup dialog (authored by rempt).
Remove the resource blacklist cleanup dialog
Mar 6 2019, 1:28 PM
rempt committed R37:3f143809a42d: Make it possible to use KisConfig if there isn't a QApplication yet (authored by rempt).
Make it possible to use KisConfig if there isn't a QApplication yet
Mar 6 2019, 12:01 PM
rempt committed R37:598295948641: Mark kis_derived_resources_test as broken (authored by rempt).
Mark kis_derived_resources_test as broken
Mar 6 2019, 12:01 PM
rempt committed R37:5866be9d1a8e: Just pass the image to the icon widget, not the whole resource. (authored by rempt).
Just pass the image to the icon widget, not the whole resource.
Mar 6 2019, 11:04 AM
rempt committed R37:48e48d50bdc5: Merge branch 'master' into rempt/T379-resource-management (authored by rempt).
Merge branch 'master' into rempt/T379-resource-management
Mar 6 2019, 9:50 AM
rempt committed R37:964ce1449b3b: Remove the integration of KisIconWidget with KisResourceServerAdapter (authored by rempt).
Remove the integration of KisIconWidget with KisResourceServerAdapter
Mar 6 2019, 9:47 AM
rempt committed R37:871f0cf570aa: Add a basic metadata system to KoResource (authored by rempt).
Add a basic metadata system to KoResource
Mar 6 2019, 9:04 AM
rempt committed R37:409af7b7e50a: Add tasksets to the resource types (authored by rempt).
Add tasksets to the resource types
Mar 6 2019, 9:04 AM
rempt committed R37:e395d278e729: Fix crash by temporarily checking the resource server pointer (authored by rempt).
Fix crash by temporarily checking the resource server pointer
Mar 6 2019, 9:04 AM
rempt committed R37:40777e671aaa: Remove the separate call to loadResourceTags (authored by rempt).
Remove the separate call to loadResourceTags
Mar 6 2019, 9:04 AM
rempt committed R37:936acfd2dbe7: Rename loadResources to registerResources (authored by rempt).
Rename loadResources to registerResources
Mar 6 2019, 9:04 AM
rempt committed R37:0a9fd8ecb8f4: KoResourceServerAdapter::serverType() is no longer used. (authored by rempt).
KoResourceServerAdapter::serverType() is no longer used.
Mar 6 2019, 9:04 AM
rempt committed R37:e12bdb45c54b: Port away from KoResourceServer (authored by rempt).
Port away from KoResourceServer
Mar 6 2019, 9:04 AM
rempt committed R37:11c83a7f6434: Port away from KoResourceServer (authored by rempt).
Port away from KoResourceServer
Mar 6 2019, 9:04 AM