Feed Advanced Search

Nov 11 2019

akomakhin updated the diff for D24852: Remove list style from headings.

OK, let's set formatSpecification explicitly to Empty if "num-format" value is empty. OASIS 1.2 says, in cases "an empty string" or "no value" is given, then no number sequence is displayed.

Nov 11 2019, 9:09 AM · Calligra: 3.0
akomakhin added a comment to D24852: Remove list style from headings.

According to this is it correct to set formatSpecification to Empty if "num-format" value is empty in all lists, not only in headings?

Nov 11 2019, 8:41 AM · Calligra: 3.0

Nov 8 2019

akomakhin added a comment to D24852: Remove list style from headings.

But there is a simple statement in loadOdf function: if "num-format" is empty, then formatSpecification has a default value -- Numeric style. Isn't it strange, assuming all list styles numerical?

Nov 8 2019, 3:47 PM · Calligra: 3.0
akomakhin updated the diff for D24852: Remove list style from headings.
Nov 8 2019, 3:16 PM · Calligra: 3.0

Oct 25 2019

akomakhin added a comment to D24852: Remove list style from headings.

All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case

Oct 25 2019, 4:54 PM · Calligra: 3.0
akomakhin added a comment to D24852: Remove list style from headings.

I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases

Oct 25 2019, 1:48 PM · Calligra: 3.0

Oct 22 2019

akomakhin updated the summary of D24852: Remove list style from headings.
Oct 22 2019, 9:08 AM · Calligra: 3.0
akomakhin added reviewers for D24852: Remove list style from headings: pvuorela, Calligra: 3.0.
Oct 22 2019, 9:05 AM · Calligra: 3.0
akomakhin requested review of D24852: Remove list style from headings.
Oct 22 2019, 9:05 AM · Calligra: 3.0

Oct 21 2019

akomakhin updated the diff for D24830: Add support for strikeout text in RTF documents.

Fixed set value from "true" to expression " ! hasValue || ( hasValue && value != 0 ) "

Oct 21 2019, 2:27 PM · Calligra: 3.0
akomakhin requested review of D24830: Add support for strikeout text in RTF documents.
Oct 21 2019, 1:57 PM · Calligra: 3.0