This change seems to break a large number of unit tests. Specifically, they fail in KoResourcePaths::assertReady().

In D6619#125907, @razvanr wrote:

@jounip, seems the paste you added is password protected.

In D6619#125840, @razvanr wrote:

Right, that's what I thought. And with that in mind... I have no idea how to speed this up... I'm open to any suggestions :)

Sorry to add the further confusion, but I got confused myself. The geometry involved is actually a bit more complicated as the tiling of the pattern is not axis aligned to the canvas.

In D6619#124196, @razvanr wrote:

The other constructor rotates around X & Y, not Z as we need here. What does fillPainter.fillRect(x - 1, y - 1, rect.width() + 2, rect.height() + 2, m_mask, m_maskBounds); do? Does it fill a rectangular region with top left corner at (x - 1, y - 1)? I assumed that but it can't be right, because I try applying the inverse translation and it just doesn't match.

So I was trying:

// after line 403 in the diff
double z = sqrt(rect.width() * rect.width() + rect.height() * rect.height());
 
// after 407
QTransform tf;
tf.translate(-x + 1 - (z + 2)/2.0, -y + 1 - (z + 2)/2.0);
tf.rotate(m_rotation);
tf.translate(x - 1 + (z + 2)/2.0, y - 1 + (z + 2)/2.0);
KisPerspectiveTransformWorker worker(fillDevice, tf, NULL);
worker.run();

And replace rect.width(), rect.height() with z before the for. But this doesn't work as expected...

I would suggest having an object to represent a keyframe, as there are a fair number of properties they have. Specifically, all keyframes have time and color label. Opacity frames have their value, interpolation modes and tangents. Raster frames of course have pixel data.

In D2801#52160, @woltherav wrote:

1. Add new keyframe in the animation curves docker doesn't work. Doing new opacity-keyframe via the regular animation docker does work.
2. I cannot see any curves in the editor when doing a simple frame 1 to 3 fade-out with two opacity frames. The terminal spits out the following: ` QPainterPath::arcTo: Adding arc where a parameter is NaN, results are undefined ` It does this about a gazillion times. I have the curves docker undocked, but I doubt this has any effect on the code.