That's right, but something seems to be off with your local clone when compared to upstream/frameworks:
$ arc patch D10806
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D10806.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Mar 3 2018
Mar 3 2018
kmorwinski added a reviewer for D11002: Various improvements/fixes in GeneratorThread::run(): asturmlechner.
Feb 27 2018
Feb 27 2018
Feb 25 2018
Feb 25 2018
In D10806#213583, @asturmlechner wrote:Thanks for your contribution! I've tested this against frameworks branch and it builds fine for me. However, your review is targeting master, which is not yet frameworks based. Merging frameworks should only happen when the branch is deemed ready, and in coordination with translations.
Please change to frameworks branch and update this revision.
Feb 24 2018
Feb 24 2018
kmorwinski added 6 commit(s) for D10806: Finalize the transition to the new plugin loading system.: R657:7ae406a65ae4: Drop obsolete K_EXPORT_PLUGIN(), R657:6aae6fa9bb7f: Add json metadata to backend plugins, R657:f56b6cf952b7: Replace the deprecated KPluginInfo class with KPluginMetata, R657:c149fdd88f0b: Print proper error message when plugin loading fails, R657:8f9fbb47a1c9: Use modern plugin finding and loading in favor of KServiceTypeTrader, R657:b2b77cda3f85: Do not install backends desktopfiles.
I accidentally included a commit which is not related to the frameworks porting work. I will close this review and open a new one.
I'm sorry! Still playing around with arc here...
Oct 12 2017
Oct 12 2017
This is a test notification, sent at Thu, Oct 12, 21:56.
This is a test notification, sent at Thu, Oct 12, 21:56.