kmorwinski (Kai Morwinski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2017, 7:52 PM (340 w, 5 d)
Availability
Available

Recent Activity

Mar 3 2018

kmorwinski added a reviewer for D11002: Various improvements/fixes in GeneratorThread::run(): asturmlechner.
Mar 3 2018, 10:54 PM
kmorwinski updated the summary of D11002: Various improvements/fixes in GeneratorThread::run().
Mar 3 2018, 10:53 PM
kmorwinski updated the summary of D11002: Various improvements/fixes in GeneratorThread::run().
Mar 3 2018, 10:53 PM
kmorwinski updated the summary of D11002: Various improvements/fixes in GeneratorThread::run().
Mar 3 2018, 10:51 PM
kmorwinski updated the summary of D11002: Various improvements/fixes in GeneratorThread::run().
Mar 3 2018, 10:50 PM
kmorwinski requested review of D11002: Various improvements/fixes in GeneratorThread::run().
Mar 3 2018, 10:47 PM
kmorwinski added a reviewer for D10999: Port cirkuit's main.cpp to KF5: asturmlechner.
Mar 3 2018, 8:34 PM
kmorwinski requested review of D10999: Port cirkuit's main.cpp to KF5.
Mar 3 2018, 8:33 PM

Feb 27 2018

kmorwinski added a comment to D10806: Finalize the transition to the new plugin loading system..

That's right, but something seems to be off with your local clone when compared to upstream/frameworks:

$ arc patch D10806
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D10806.

Feb 27 2018, 10:22 PM

Feb 25 2018

kmorwinski added a comment to D10806: Finalize the transition to the new plugin loading system..

Thanks for your contribution! I've tested this against frameworks branch and it builds fine for me. However, your review is targeting master, which is not yet frameworks based. Merging frameworks should only happen when the branch is deemed ready, and in coordination with translations.

Please change to frameworks branch and update this revision.

Feb 25 2018, 9:19 PM
kmorwinski removed a watcher for Frameworks: kmorwinski.
Feb 25 2018, 8:58 PM

Feb 24 2018

kmorwinski added an edge to R657:7ae406a65ae4: Drop obsolete K_EXPORT_PLUGIN(): D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski added 6 commit(s) for D10806: Finalize the transition to the new plugin loading system.: R657:7ae406a65ae4: Drop obsolete K_EXPORT_PLUGIN(), R657:6aae6fa9bb7f: Add json metadata to backend plugins, R657:f56b6cf952b7: Replace the deprecated KPluginInfo class with KPluginMetata, R657:c149fdd88f0b: Print proper error message when plugin loading fails, R657:8f9fbb47a1c9: Use modern plugin finding and loading in favor of KServiceTypeTrader, R657:b2b77cda3f85: Do not install backends desktopfiles.
Feb 24 2018, 7:28 PM
kmorwinski added an edge to R657:f56b6cf952b7: Replace the deprecated KPluginInfo class with KPluginMetata: D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski added an edge to R657:b2b77cda3f85: Do not install backends desktopfiles: D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski added an edge to R657:6aae6fa9bb7f: Add json metadata to backend plugins: D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski added an edge to R657:8f9fbb47a1c9: Use modern plugin finding and loading in favor of KServiceTypeTrader: D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski added an edge to R657:c149fdd88f0b: Print proper error message when plugin loading fails: D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:28 PM
kmorwinski requested review of D10806: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:26 PM
kmorwinski abandoned D10805: Finalize the transition to the new plugin loading system..

I accidentally included a commit which is not related to the frameworks porting work. I will close this review and open a new one.
I'm sorry! Still playing around with arc here...

Feb 24 2018, 7:20 PM
kmorwinski requested review of D10805: Finalize the transition to the new plugin loading system..
Feb 24 2018, 7:11 PM
kmorwinski added a watcher for Frameworks: kmorwinski.
Feb 24 2018, 7:08 PM

Oct 12 2017

This is a test notification, sent at Thu, Oct 12, 21:56.
Oct 12 2017, 7:56 PM
This is a test notification, sent at Thu, Oct 12, 21:56.
Oct 12 2017, 7:56 PM