Feed Advanced Search

May 24 2020

brauch committed R39:c374e2691487: Merge remote-tracking branch 'origin/minimap-unseen-views' (authored by brauch).
Merge remote-tracking branch 'origin/minimap-unseen-views'
May 24 2020, 3:21 PM

May 23 2020

brauch committed R39:ae403a930201: scrollbar minimap: performance: delay update for inactive documents (authored by brauch).
scrollbar minimap: performance: delay update for inactive documents
May 23 2020, 11:38 AM
brauch committed R32:10e175a755c8: problem view: faster implementation of resizeColumnsToContents (authored by brauch).
problem view: faster implementation of resizeColumnsToContents
May 23 2020, 11:30 AM

May 17 2020

brauch added a comment to D29789: Make text always align with font base line.

Hmm, consider though that a configuration option should be something that gives a choice to the user. It shouldn't be necessary to set a config option in order to make the program behave correctly.

May 17 2020, 5:34 PM · Frameworks, Kate

May 5 2020

brauch added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I second the as-an-option proposal. Hey, why not automatically increase the line height when CJK characters are detected?

May 5 2020, 3:50 PM · Frameworks, Kate

Apr 3 2020

brauch added a comment to D28287: Undo cursor move.

Patches naturally get more attention than feature requests in bug reports, because even if in the feature request everyone agrees it's a nice idea you still have to find somebody to actually do it -- which is often not the case ;) and then it's just wasted time to discuss it in the first place.

Apr 3 2020, 11:31 PM · Kate

Mar 25 2020

brauch added a comment to D28287: Undo cursor move.

The 10 line limit also seems kind of arbitrary to me. KDevelop has a similar navigation feature and navigates by "contexts". A similar concept exists in KTextEditor in terms of the folding ranges; maybe that could be used to classify "meaningful" cursor moves to navigate between?

Mar 25 2020, 11:18 PM · Kate

Mar 7 2020

brauch added a comment to D27912: Draw inlineNotes after drawing word wrap marker.

I also don't understand this. Even if the painting somehow changes, e.g. because some painter state is set which wasnt set before (which I do not see to be the case here), that should not affect the line layout, as that is computed separately.

Mar 7 2020, 5:43 PM · Frameworks, Kate
brauch accepted D27912: Draw inlineNotes after drawing word wrap marker.

Looks good, thanks! Yes, it's an improvement.

Mar 7 2020, 3:39 PM · Frameworks, Kate

Jan 25 2020

brauch closed D26840: Correctly set underMouse() for inline notes.
Jan 25 2020, 8:58 AM · Frameworks, Kate
brauch committed R39:7f043fbb26d4: inline notes: correctly set underMouse() for inline notes (authored by brauch).
inline notes: correctly set underMouse() for inline notes
Jan 25 2020, 8:58 AM
brauch added a comment to D26840: Correctly set underMouse() for inline notes.

Ok, done ;)

Jan 25 2020, 8:57 AM · Frameworks, Kate
brauch accepted D26840: Correctly set underMouse() for inline notes.

If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution.

Jan 25 2020, 8:27 AM · Frameworks, Kate

Jan 24 2020

brauch added a comment to D26840: Correctly set underMouse() for inline notes.

I'm sorry, updateView is the wrong function to call, you need updateDirty. I tried it out, like this it works:

Jan 24 2020, 8:56 PM · Frameworks, Kate

Jan 23 2020

brauch added a comment to D26840: Correctly set underMouse() for inline notes.

Then it seems like the line is not tagged correctly. Maybe try tagLines(note.position.line(), note.position.line())? I think the column being the same is not what the function being called expects.

Jan 23 2020, 7:50 PM · Frameworks, Kate

Jan 22 2020

brauch added a comment to D26840: Correctly set underMouse() for inline notes.

My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is tagged dirty, it gets repainted correctly, but too late.

Jan 22 2020, 7:22 PM · Frameworks, Kate
brauch added a comment to D26840: Correctly set underMouse() for inline notes.

Hm, yeah, looking at the code I think you might need to call updateView() in case a focus in or out happened. Can you try if that makes a difference?

Jan 22 2020, 7:19 PM · Frameworks, Kate
brauch added a comment to D26840: Correctly set underMouse() for inline notes.

Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing.

Jan 22 2020, 6:05 PM · Frameworks, Kate