Closing this revision. Let's get D29223 in.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
May 6 2020
May 6 2020
weisi abandoned D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list.
Closing this revision. Let's get D29223 in.
May 4 2020
May 4 2020
Thanks! Looks good :)
May 3 2020
May 3 2020
weisi added a comment to D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list.
I agree with the general idea in D29223 and feel D29223 is in a better shape than this diff. However, I think some festivals referred to in this diff (not mentioned in the law - 紀念日及節日實施辦法 - but are still special days of interest that many people celebrate) can be adapted into D29223.
I prefer this diff to the changes I took in D29373. I wish I had seen this diff earlier.
I think the approach in D29223 (renaming the file also) is more preferred.
weisi requested review of D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday.
weisi updated the diff for D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list.
Renamed "農曆除夕" (Lunar New Year's eve on Lunar calendar) to "除夕" (Lunar New Year's eve). There's no need to specify "lunar calendar" here.
Adding a reviewer to this diff. Thanks!