Update as per request.

Yeah that was why I was asking. :(

I'm really not sure anymore. At a guess, I'd say the diff itself is different and I probably overlooked something so that's why there's a new review request instead of continuing the old one.
Anyway should I use arc amend and then git push origin frameworks to land this in the frameworks branch?

Fix typo.

Sorry for the confusion with the new/redundant review request.
Let's continue the review/discussion here: https://phabricator.kde.org/D5545

Yes, courtesy of arc diff.

So do you want me to restore the default, i.e remove the "history.immutability" option?

In D5543#104029, @ltoscano wrote:

Thanks! If you have committed this on top of the original branch (probably master, which is still the official branch), arc land should be enough to commit it.

Updating D5544: Summary:

Port usage of KUrl and friends to equivalent constructs with QUrl.
KUrl is part of the deprecated kdelibs4support API.
Porting away from it removes one obstacle towards legacy free sudoku for KDE.

Edited the various fields using the Phabricator UI instead, please let me know if this is more like what you were looking for instead.

Reformat commit message, conform to guidlines from review comments.

In order to amend the content of a review, amend the local commit and re-run arc diff, but this does not change the commit message.

Thanks for your review!
This is my first try with arcanist. Clearly not 100% success on the first try, it mangled my intended commit message.

Fixed in commit: e51257ac9304238982ee38ca6da9acd91dadab02

http://doc.qt.io/qtcreator/creator-qml-modules-with-plugins.html