Create Task
Maniphest T5533

Regression: commit 3553ca6d414764dc72c2415099bf2f87f1a93918 broke qmlscene preview
Closed, ResolvedPublic
Actions

Description

As of commit 3553ca6d414764dc72c2415099bf2f87f1a93918 Kirigami based UIs no longer load theme icons such as "document-edit" when previewed with qmlscene.
This breaks code such as:

Kirigami.ApplicationWindow {
  globalDrawer: Kirigami.GlobalDrawer {
    actions: [
      Kirigami.Action {
        text: "Demonstrate the bug"
        iconName: "tools-report-bug"
      }
    ]
  }
}

Reverting to a90b442d06b3b64dd681c84dcc7aa8c61fa53a29 makes qmlscene work again.

Please, unbreak this now! (Or update documentation to explain how to preview with qmlscene again.)

Related Objects

ouwerkerk created this task.Mar 5 2017, 1:30 PM
mart closed this task as Resolved.Mar 6 2017, 12:50 PM
mart claimed this task.
mart added a subscriber: mart.

should be solved in
https://commits.kde.org/kirigami/e51257ac9304238982ee38ca6da9acd91dadab02

the check on isNull on the qicon was always returning false (as it did have a name, that may have been invalid)