Feed Advanced Search

Jul 18 2019

shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Add function to revoke authorization

Jul 18 2019, 2:09 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

remove code causing false statement

Jul 18 2019, 7:01 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 18 2019, 6:50 AM · KDE Partition Manager

Jul 15 2019

shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Return false when action not authorized

Jul 15 2019, 2:31 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Initialize helper and connect to signals

Jul 15 2019, 2:26 PM · KDE Partition Manager

Jul 14 2019

shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt auth-polkit-backend patch

Jul 14 2019, 4:37 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Do not make virtual function, was just testing

Jul 14 2019, 4:32 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Make functions virtual

Jul 14 2019, 4:04 PM · KDE Partition Manager

Jul 13 2019

stikonas added a comment to D22321: Add unit test for Polkit backend.

Looks alright. I'll try to compile myself and see what are those linking errors when you have those two lines uncommented...

Jul 13 2019, 4:15 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 13 2019, 4:03 PM · KDE Partition Manager
shubham added inline comments to D22321: Add unit test for Polkit backend.
Jul 13 2019, 4:00 PM · KDE Partition Manager
shubham removed a dependent revision for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham edited dependencies for D22321: Add unit test for Polkit backend, added: 1; removed: 1.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham added a dependent revision for D22438: Authorize using Polkit backend and compile Helper as standalone application: D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:59 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 13 2019, 3:58 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Add QTest to cmake

Jul 13 2019, 3:57 PM · KDE Partition Manager
shubham requested review of D22438: Authorize using Polkit backend and compile Helper as standalone application.
Jul 13 2019, 2:14 PM · KDE Partition Manager

Jul 12 2019

shubham closed D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 2:39 PM · KDE Partition Manager
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 8:24 AM · KDE Partition Manager
shubham removed a dependency for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 8:20 AM · KDE Partition Manager
shubham removed a dependent revision for D21773: [WIP]: QDBus communication from helper towards Application: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 8:20 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Comment out connects for now

Jul 12 2019, 8:17 AM · KDE Partition Manager
shubham reopened D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 7:07 AM · KDE Partition Manager
shubham reopened D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 6:33 AM · KDE Partition Manager
shubham closed D21773: [WIP]: QDBus communication from helper towards Application.
Jul 12 2019, 6:32 AM · KDE Partition Manager
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 6:32 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Rebase wrt qdbus patch

Jul 12 2019, 6:26 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Comment out connects for now

Jul 12 2019, 6:24 AM · KDE Partition Manager
shubham added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 12 2019, 4:32 AM · KDE Partition Manager

Jul 11 2019

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:19 PM · KDE Partition Manager
shubham added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:58 AM · KDE Partition Manager
shubham added a dependent revision for D21773: [WIP]: QDBus communication from helper towards Application: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham added a dependency for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D21773: [WIP]: QDBus communication from helper towards Application.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham updated the summary of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:45 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove KAuth dependence

Jul 11 2019, 8:44 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

Remove extra include

Jul 11 2019, 7:37 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

include moc

Jul 11 2019, 7:35 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

Proper rebase and fix merge conflicts with Polkit backend

Jul 11 2019, 7:18 AM · KDE Partition Manager

Jul 10 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unnecessary include

Jul 10 2019, 8:05 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Add timer to quit()

Jul 10 2019, 8:03 AM · KDE Partition Manager
shubham added a dependent revision for D21970: [WIP]: Implement PolkitQt1 Authorization backend: D22321: Add unit test for Polkit backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager
shubham added a dependency for D22321: Add unit test for Polkit backend: D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Jul 10 2019, 7:21 AM · KDE Partition Manager

Jul 9 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Now compiles, authorizing using the Polkit backend

Jul 9 2019, 7:42 AM · KDE Partition Manager
shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

cleanup

Jul 9 2019, 6:26 AM · KDE Partition Manager

Jul 8 2019

shubham added a project to D22321: Add unit test for Polkit backend: KDE Partition Manager.
Jul 8 2019, 9:31 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Authenticate org.kde.kpmcore.externalcommand.init action inside ExternalCommand::startHelper() using Polkit Backend
@stikonas Below error is troubling me for sometime.

Jul 8 2019, 5:01 AM · KDE Partition Manager

Jul 7 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unneded function

Jul 7 2019, 8:00 AM · KDE Partition Manager

Jul 5 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

More cleanup and remove unneded commented code

Jul 5 2019, 2:59 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Add function to stop action inside the polkit backend

Jul 5 2019, 8:02 AM · KDE Partition Manager

Jun 26 2019

shubham reopened D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 26 2019, 4:38 PM · KDE Partition Manager
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 26 2019, 4:37 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove Q_PLUGIN_METADATA

Jun 26 2019, 2:07 PM · KDE Partition Manager

Jun 24 2019

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 24 2019, 8:01 PM · KDE Partition Manager

Jun 22 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Properly handle reply from Authentication agent

Jun 22 2019, 5:49 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

More code cleanup.
Remove unnecessary includes.

Jun 22 2019, 5:27 PM · KDE Partition Manager
stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 22 2019, 9:47 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

some more changes

Jun 22 2019, 9:41 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unneeded functions

Jun 22 2019, 9:36 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Lay basic outline of executing and revoking actions from inside ExternalCommand

Jun 22 2019, 9:27 AM · KDE Partition Manager

Jun 21 2019

shubham updated the summary of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 21 2019, 5:55 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Correct documentation error.
@stikonas I will be making more changes to it and will implement those Q_SLOTS soon.
(sendProgressStep())

Jun 21 2019, 5:52 PM · KDE Partition Manager
shubham updated the test plan for D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 21 2019, 5:50 PM · KDE Partition Manager
shubham added a project to D21970: [WIP]: Implement PolkitQt1 Authorization backend: KDE Partition Manager.
Jun 21 2019, 5:50 PM · KDE Partition Manager

Jun 20 2019

shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

A bit cleanup

Jun 20 2019, 2:00 PM · KDE Partition Manager

Jun 19 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
Jun 19 2019, 4:41 PM · KDE Partition Manager

Jun 16 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Use correct signal

Jun 16 2019, 7:47 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add documentation

Jun 16 2019, 7:37 PM · KDE Partition Manager

Jun 15 2019

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

I think QSignalSpy is in QtTest, not QtWidgets.

Jun 15 2019, 7:25 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
  1. Use synchronous versions of register and unregistering authentication agents
  2. Call authenticationAgentResponseSync() on successfull authentication by the user
Jun 15 2019, 7:13 PM · KDE Partition Manager

Jun 12 2019

shubham retitled D21773: [WIP]: QDBus communication from helper towards Application from [WIP] :QDBus communication from helper towards Application to [WIP]: QDBus communication from helper towards Application.
Jun 12 2019, 7:57 PM · KDE Partition Manager
shubham updated the summary of D21773: [WIP]: QDBus communication from helper towards Application.
Jun 12 2019, 7:57 PM · KDE Partition Manager
shubham added a project to D21773: [WIP]: QDBus communication from helper towards Application: KDE Partition Manager.
Jun 12 2019, 7:56 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Rebase on master

Jun 12 2019, 4:54 PM · KDE Partition Manager

Jun 10 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add more functions

Jun 10 2019, 4:22 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Do not include PolkitQt5 directories

Jun 10 2019, 2:51 PM · KDE Partition Manager

Jun 9 2019

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

So far rest seems alright.

Jun 9 2019, 10:08 PM · KDE Partition Manager

Jun 8 2019

shubham closed D21653: Add Minix Filesystem.
Jun 8 2019, 6:32 PM · KDE Partition Manager
shubham closed D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 6:31 PM · KDE Partition Manager
shubham updated the summary of D21653: Add Minix Filesystem.
Jun 8 2019, 6:30 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.
Jun 8 2019, 6:29 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Fix copy paste error

Jun 8 2019, 6:24 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.

Once issues mentioned above are fixed.

Jun 8 2019, 6:19 PM · KDE Partition Manager
stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 6:15 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Make requested changes

Jun 8 2019, 6:13 PM · KDE Partition Manager
stikonas requested changes to D21653: Add Minix Filesystem.
Jun 8 2019, 5:59 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:53 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:45 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:25 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Correct tool name and website

Jun 8 2019, 5:11 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 4:46 PM · KDE Partition Manager
shubham closed D21616: Quit application if bus is not connected, interface not registered.
Jun 8 2019, 10:14 AM · KDE Partition Manager
stikonas accepted D21616: Quit application if bus is not connected, interface not registered.
Jun 8 2019, 10:07 AM · KDE Partition Manager
stikonas added a comment to D21616: Quit application if bus is not connected, interface not registered.

Oh, I see. Sorry for missing that out. Then I guess commit it to master.

Jun 8 2019, 10:07 AM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Made suggested changes

Jun 8 2019, 10:00 AM · KDE Partition Manager
shubham added a comment to D21616: Quit application if bus is not connected, interface not registered.

This is seprate from the patch sitter had made. Here, application quitting is inside if.

Jun 8 2019, 9:42 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 8:54 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 8:53 AM · KDE Partition Manager
stikonas requested changes to D21616: Quit application if bus is not connected, interface not registered.

If you want this commit, you can just merge master branch into your branch.

Jun 8 2019, 8:50 AM · KDE Partition Manager
shubham added a comment to D21652: Add support for Minix(Mini Unix) Filesystem.

Thread 8 "m_DeviceScanner" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffca6df700 (LWP 4074)]
0x00007ffff5934148 in vtable for QTreeWidgetItem () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
(gdb) bt
#0 0x00007ffff5934148 in vtable for QTreeWidgetItem () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#1 0x00007ffff447e9d2 in QObject::connect(QObject const*, char const*, QObject const*, char const*, Qt::ConnectionType) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2 0x00007ffff7b85d85 in ExternalCommand::copyBlocks(CopySource const&, CopyTarget&) (this=this@entry=0x7fffca6de8b0, source=..., target=...) at /home/aryan/kde/src/kpmcore/src/util/externalcommand.cpp:185
#3 0x00007fffddf01e0e in SfdiskBackend::updateDevicePartitionTable(Device&, QJsonObject const&) (this=this@entry=0x5555558fe8d0, d=..., jsonPartitionTable=...)

at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:364

#4 0x00007fffddf04a4e in SfdiskBackend::scanDevice(QString const&) (this=0x5555558fe8d0, deviceNode=...) at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:212
#5 0x00007fffddf017e7 in SfdiskBackend::scanDevices(QFlags<ScanFlag>) (this=0x5555558fe8d0, scanFlags=...) at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:115
#6 0x00007ffff7b37106 in DeviceScanner::scan() (this=0x5555558f6920) at /home/aryan/kde/src/kpmcore/src/core/devicescanner.cpp:66
#7 0x00007ffff4270bc2 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8 0x00007ffff04a46db in start_thread (arg=0x7fffca6df700) at pthread_create.c:463
#9 0x00007ffff3b7088f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 0
Invalid thread ID: 0
(gdb) thread 1
[Switching to thread 1 (Thread 0x7ffff7fa5840 (LWP 4005))]
#0 0x00007ffff3b5f0b4 in GI_libc_read (fd=5, buf=0x7fffffffd850, nbytes=16) at ../sysdeps/unix/sysv/linux/read.c:27

Jun 8 2019, 6:06 AM · KDE Partition Manager