Feed Advanced Search

May 2 2020

tbaumgart closed D29255: Fix ordinate axis labels when zooming.
May 2 2020, 5:12 AM · KDiagram, KMyMoney

May 1 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

With the priceless help from @tbaumgart I managed to find a solution. Please find attached the final version of the patch.

May 1 2020, 9:28 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

I have done some more testing and I realized that precision (number of digits after the decimal point) is subject to change. In fact, account balance history chart is pretty straightforward but the code that I worked with is also used with configurable charts in reports. Precision can be changed in the Range tab of the Report Configuration window.
My previous patch created yAxis by calling new KReportCartesianAxis(loc, m_precision) whereas it should be new KReportCartesianAxis(loc, config.yLabelsPrecision()).

May 1 2020, 12:37 PM · KDiagram, KMyMoney

Apr 30 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.
Apr 30 2020, 7:40 AM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

0.0 is quite a special argument for the logarithm. I made one last change adding support for this case.

Apr 30 2020, 7:30 AM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Also there was a todo comment in the code I have removed, so thought it to be appropriate to take care of it lest it be missed out.

/ @todo this might also need some vertical adjustment in case of a horizontal line
/ see below how this has been solved for linear graphs

Indeed, support for logarithmic axis type was required.
Now I think the code is robust and complete. Now I'll just wait for the final review from you :)

Apr 30 2020, 7:03 AM · KDiagram, KMyMoney
tbaumgart added a comment to D29255: Fix ordinate axis labels when zooming.

Still looks OK to me. Push it.

Apr 30 2020, 6:51 AM · KDiagram, KMyMoney

Apr 29 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

There is one thing I overlooked in my previous revision. I have just tested my changes against a new account with clear history (empty ledger). It leads to a horizontal-line chart that is drawn incorrectly if no custom grid extension is made. The conclusion is the original grid extension code is here to stay. I have just moved it from void KReportChartView::slotNeedUpdate() to the bottom of void KReportChartView::drawPivotChart( ... ) and I refactored a little bit. Sorry for messing around in this already accepted patch. The good thing is labels are now printed correctly even when one zooms a horizontal-line chart :)

Apr 29 2020, 10:41 PM · KDiagram, KMyMoney
rszczesiak added inline comments to D29255: Fix ordinate axis labels when zooming.
Apr 29 2020, 8:12 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.
Apr 29 2020, 8:04 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Thank you, @tbaumgart for your time spent reviewing my changes. I have amended my commit message with tag "BUG: 420767"

Apr 29 2020, 7:44 PM · KDiagram, KMyMoney
tbaumgart added a comment to D29255: Fix ordinate axis labels when zooming.

Do we have a bug entry for this one? If not, please create one and add

Apr 29 2020, 4:46 PM · KDiagram, KMyMoney
tbaumgart accepted D29255: Fix ordinate axis labels when zooming.

Looks good to me.

Apr 29 2020, 4:45 PM · KDiagram, KMyMoney

Apr 28 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Uploaded a new diff patch after changes according to @tbaumgart's comments.

Apr 28 2020, 9:20 PM · KDiagram, KMyMoney
rszczesiak added inline comments to D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 9:18 PM · KDiagram, KMyMoney
tbaumgart requested changes to D29255: Fix ordinate axis labels when zooming.

This in general is a high quality patch. Thanks much. The changes I suggest are minor details.

Apr 28 2020, 6:48 PM · KDiagram, KMyMoney
rszczesiak updated the test plan for D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 2:09 PM · KDiagram, KMyMoney
rszczesiak updated the test plan for D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 1:51 PM · KDiagram, KMyMoney
rszczesiak requested review of D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 1:18 PM · KDiagram, KMyMoney

Apr 21 2020

danders closed T8276: Release 2.7 as Resolved.

Done and branched, no more freeze.

Apr 21 2020, 11:27 AM · KDiagram

Apr 16 2020

danders added a comment to T8276: Release 2.7.

Finally ready for a release.
Plan is:
String freeze from today. (only a coule of strings)
Release Tuesday 21.

Apr 16 2020, 9:24 AM · KDiagram

Mar 23 2018

danders triaged T8276: Release 2.7 as Normal priority.
Mar 23 2018, 7:42 AM · KDiagram

Feb 23 2018

danders triaged T8060: Calligra plan Gantt text color as Normal priority.
Feb 23 2018, 2:41 PM · KDiagram

Jan 10 2018

tbaumgart added a member for KDiagram: tbaumgart.
Jan 10 2018, 8:14 AM

Jan 8 2018

danders added a member for KDiagram: danders.
Jan 8 2018, 7:52 AM

Jan 6 2018

bcooksley created KDiagram.
Jan 6 2018, 9:06 PM