rszczesiak (Robert Szczesiak)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 28 2020, 8:28 AM (5 w, 2 d)
Availability
Available

Recent Activity

Fri, May 29

rszczesiak committed R261:58ef131ea94e: Add copyright (authored by rszczesiak).
Add copyright
Fri, May 29, 2:36 PM
rszczesiak committed R261:8ae14acc9e89: Fix budget view displaying all account types (authored by rszczesiak).
Fix budget view displaying all account types
Fri, May 29, 2:36 PM
rszczesiak committed R261:3bf120d2b2ae: Fix report's chart cluttered with overlapping data labels (authored by rszczesiak).
Fix report's chart cluttered with overlapping data labels
Fri, May 29, 12:19 AM

Mon, May 18

rszczesiak committed R261:6e1746e3d6ea: Fix new account wizard not asking if the user wants to add a new payee (authored by rszczesiak).
Fix new account wizard not asking if the user wants to add a new payee
Mon, May 18, 6:40 PM

Sat, May 16

rszczesiak updated the diff for D29776: Fix New Account Wizard throws exception on empty payment method selected.

Added the fix for incorrect Next button tooltip messages on the Schedule page.

Sat, May 16, 6:45 AM · KMyMoney

Fri, May 15

rszczesiak added a comment to D29776: Fix New Account Wizard throws exception on empty payment method selected.

OK, I found it.
The 2nd last line of the isComplete() method should be d->m_wizard->d_func()->m_nextButton->setToolTip(msg); instead of d->m_wizard->d_func()->m_finishButton->setToolTip(msg);
Now the tooltip message informs the user why the Next button is disabled.

Fri, May 15, 8:24 PM · KMyMoney
rszczesiak added a comment to D29776: Fix New Account Wizard throws exception on empty payment method selected.

@tbaumgart, That's right. I also investigated those #if o #endif lines to find out why were they added before I decided to bring those two payment methods back and found no good reason. It might well have been only temporary and the author forgot to revert the change.

Fri, May 15, 6:44 PM · KMyMoney
rszczesiak added a comment to D29776: Fix New Account Wizard throws exception on empty payment method selected.

@ostroffjh, I agree that your concerns are important. I have just skimmed through the code and came acrosss something that may render useful.
There is a virtual method isComplete() in KMyMoneyWizardPage class.
` /**

  • This returns, if all necessary data for this page has been
  • filled. It is used to enabled the 'Next' or 'Finish' button.
  • The button is only enabled, if this method returns @p true,
  • which is the default implementation. *
  • @retval false more data required from the user before we can proceed
  • @retval true all data available, we allow to switch to the next page */ virtual bool isComplete() const;`

The method is overridden in subclass CreditCardSchedulePage which is changed by this patch.
It seems this approach works as expected on the previous page:


For some reason tooltip message is not supported correctly on the Schedule page. This needs looking into more closely to find out why.

Fri, May 15, 6:39 PM · KMyMoney
rszczesiak added a comment to D29776: Fix New Account Wizard throws exception on empty payment method selected.

The patch also disallows the user to intentionally set empty payment method. Empty method is not listed. Therefore I consider the fix quite solid.

Fri, May 15, 3:11 PM · KMyMoney
rszczesiak added a comment to D29776: Fix New Account Wizard throws exception on empty payment method selected.

What about just refusing to allow to complete the creation (instead of crashing) unless a payment method is selected, but not set a default type?

Fri, May 15, 2:57 PM · KMyMoney
rszczesiak requested review of D29776: Fix New Account Wizard throws exception on empty payment method selected.
Fri, May 15, 2:27 PM · KMyMoney

Wed, May 13

rszczesiak added a comment to D29614: Fix Account context menu's Reconcile option opens incorrect ledger.

@tbaumgart, thank you for your acceptance. Could you please land the patch for me? I do not have git push permission.

Wed, May 13, 6:51 AM · KMyMoney

Mon, May 11

rszczesiak added a project to D29614: Fix Account context menu's Reconcile option opens incorrect ledger: KMyMoney.
Mon, May 11, 10:01 AM · KMyMoney

Sun, May 10

rszczesiak added a reviewer for D29614: Fix Account context menu's Reconcile option opens incorrect ledger: tbaumgart.
Sun, May 10, 10:17 PM · KMyMoney
rszczesiak requested review of D29614: Fix Account context menu's Reconcile option opens incorrect ledger.
Sun, May 10, 10:16 PM · KMyMoney

Fri, May 8

rszczesiak updated the diff for D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.

Removed unnecessary function declaration.

Fri, May 8, 10:10 AM · KMyMoney
rszczesiak updated the diff for D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.

Added the requested changes.

Fri, May 8, 10:07 AM · KMyMoney

Wed, May 6

rszczesiak added a comment to D29480: Fix Logarithmic vertical axis has multiple zero labels.

Thanks :) I really like to see that charts work as expected.

Wed, May 6, 8:01 PM · KMyMoney
rszczesiak added inline comments to D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.
Wed, May 6, 6:35 PM · KMyMoney
rszczesiak added a comment to D29480: Fix Logarithmic vertical axis has multiple zero labels.

Before fix:

Wed, May 6, 1:37 PM · KMyMoney
rszczesiak added a project to D29480: Fix Logarithmic vertical axis has multiple zero labels: KMyMoney.
Wed, May 6, 12:07 PM · KMyMoney
rszczesiak requested review of D29480: Fix Logarithmic vertical axis has multiple zero labels.
Wed, May 6, 12:05 PM · KMyMoney
rszczesiak updated the diff for D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.

Simlified c'tor arguments. Removed unnecessary if statement. Added identation.

Wed, May 6, 7:41 AM · KMyMoney

Tue, May 5

rszczesiak added a project to D29446: Fix Freeze: logarithmic vertical axis and negative data range From value: KMyMoney.
Tue, May 5, 7:27 PM · KMyMoney
rszczesiak updated the diff for D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.

Fixed typos in the commit message

Tue, May 5, 6:05 PM · KMyMoney
rszczesiak updated the diff for D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.
Tue, May 5, 3:27 PM · KMyMoney
rszczesiak updated the summary of D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.
Tue, May 5, 2:31 PM · KMyMoney
rszczesiak requested review of D29446: Fix Freeze: logarithmic vertical axis and negative data range From value.
Tue, May 5, 1:19 PM · KMyMoney

May 1 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

With the priceless help from @tbaumgart I managed to find a solution. Please find attached the final version of the patch.

May 1 2020, 9:28 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

I have done some more testing and I realized that precision (number of digits after the decimal point) is subject to change. In fact, account balance history chart is pretty straightforward but the code that I worked with is also used with configurable charts in reports. Precision can be changed in the Range tab of the Report Configuration window.
My previous patch created yAxis by calling new KReportCartesianAxis(loc, m_precision) whereas it should be new KReportCartesianAxis(loc, config.yLabelsPrecision()).

May 1 2020, 12:37 PM · KDiagram, KMyMoney

Apr 30 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.
Apr 30 2020, 7:40 AM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

0.0 is quite a special argument for the logarithm. I made one last change adding support for this case.

Apr 30 2020, 7:30 AM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Also there was a todo comment in the code I have removed, so thought it to be appropriate to take care of it lest it be missed out.

/ @todo this might also need some vertical adjustment in case of a horizontal line
/ see below how this has been solved for linear graphs

Indeed, support for logarithmic axis type was required.
Now I think the code is robust and complete. Now I'll just wait for the final review from you :)

Apr 30 2020, 7:03 AM · KDiagram, KMyMoney

Apr 29 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

There is one thing I overlooked in my previous revision. I have just tested my changes against a new account with clear history (empty ledger). It leads to a horizontal-line chart that is drawn incorrectly if no custom grid extension is made. The conclusion is the original grid extension code is here to stay. I have just moved it from void KReportChartView::slotNeedUpdate() to the bottom of void KReportChartView::drawPivotChart( ... ) and I refactored a little bit. Sorry for messing around in this already accepted patch. The good thing is labels are now printed correctly even when one zooms a horizontal-line chart :)

Apr 29 2020, 10:41 PM · KDiagram, KMyMoney
rszczesiak added inline comments to D29255: Fix ordinate axis labels when zooming.
Apr 29 2020, 8:12 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.
Apr 29 2020, 8:04 PM · KDiagram, KMyMoney
rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Thank you, @tbaumgart for your time spent reviewing my changes. I have amended my commit message with tag "BUG: 420767"

Apr 29 2020, 7:44 PM · KDiagram, KMyMoney

Apr 28 2020

rszczesiak updated the diff for D29255: Fix ordinate axis labels when zooming.

Uploaded a new diff patch after changes according to @tbaumgart's comments.

Apr 28 2020, 9:20 PM · KDiagram, KMyMoney
rszczesiak added inline comments to D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 9:18 PM · KDiagram, KMyMoney
rszczesiak updated the test plan for D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 2:09 PM · KDiagram, KMyMoney
rszczesiak updated the test plan for D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 1:51 PM · KDiagram, KMyMoney
rszczesiak added a watcher for KMyMoney: rszczesiak.
Apr 28 2020, 1:21 PM
rszczesiak requested review of D29255: Fix ordinate axis labels when zooming.
Apr 28 2020, 1:18 PM · KDiagram, KMyMoney