lower mouse acceleration limit to 0.0
AbandonedPublic

Authored by sitter on Dec 12 2016, 11:58 AM.

Details

Reviewers
plasma-devel
Summary

as seen in bug 95928 this used to be locked at 1 but was lowered
to 0.1 as acceleration != speed, so <1 makes perfect sense.
however, by extension, 0.0 also makes sense (no acceleration on
top of hardware input) which I think was an oversight in the
original decrease.

this change sets the lower bounds of the input field to 0.0 so
one can effectively disable acceleration

CHANGELOG: Mouse settings now allow setting acceleration to 0.0

Test Plan
  • build
  • set acceleration to 0.0
  • mouse super slow

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
sitter updated this revision to Diff 8938.Dec 12 2016, 11:58 AM
sitter retitled this revision from to lower mouse acceleration limit to 0.0.
sitter updated this object.
sitter edited the test plan for this revision. (Show Details)
sitter added a reviewer: plasma-devel.
sitter added a subscriber: jensreuterberg.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 12 2016, 11:58 AM

I think KWin's Wayland input mapping logic needs to be adjusted then?

Possibly.

The KCM does not appear to actually work on wayland though ^^

if (!QX11Info::isPlatformX11()) {
    return;
In D3650#68360, @sitter wrote:

Possibly.

The KCM does not appear to actually work on wayland though ^^

It does. I ported it and it works and adjusts the settings for Wayland if KWin is used.

Ok. Kindly take note of potential adjustment needs then.

Do I need to do something to get this moving forward?

According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value.

So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then.

From my side something between -1 and -2 for this change.

That's not really answering my question now is it?

apol added a subscriber: apol.May 30 2017, 1:18 PM

According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value.

So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then.

From my side something between -1 and -2 for this change.

Does this mean that 0.0 means not moving at all? That doesn't sound right.

In D3650#112888, @apol wrote:

According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a slow down. But it's still a factor. I'm also afraid that putting a 0.0 there could result in a devision by 0 value.

So in any case your commit message does not match the actual reality. And given that I think you are trying to fix the wrong problem. Might it be that you use the libinput xorg driver? If yes, that's not yet supported and needs porting. But this change has potential of breaking the non-libinput xorg driver then.

From my side something between -1 and -2 for this change.

Does this mean that 0.0 means not moving at all? That doesn't sound right.

It could mean a crash in X - division by zero. No idea how X handles the situation, but 0 is clearly a wrong value here.

sitter abandoned this revision.Jun 19 2018, 10:03 AM