Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
staniek |
Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
run kreportexample and ensure rendering as expected
No Linters Available |
No Unit Test Coverage |
src/common/KReportRenderObjects.cpp | ||
---|---|---|
45 | clear is not really needed | |
48 | same here | |
69 | Second arg not needed | |
74 | Second arg not needed, default constructed value is returned here, which for Qt is nullptr. | |
93 | Second arg not needed | |
98 | Second arg not needed | |
146 | For symmetry don't we want to also delete page? | |
151 | For symmetry don't we want to also delete section? | |
178 | not really needed | |
191 | not really needed | |
206 | Second arg not needed | |
211 | Second arg not needed | |
260 | For symmetry don't we want to also delete primitive? | |
275 | KReport::recordCount() is qint64 so how about using qint64 here too? | |
281 | Let's initialize all members here because it's possible. | |
310 | Second arg not needed | |
315 | Second arg not needed | |
410 | If we add delete to OROPage::removePrimitive() this line won't be correct. Either:
| |
460 | TODO: rename to KReportTextStyleData, add initialization of KReportTextStyleData::alignment and KReportTextStyleData::backgroundOpacity. | |
472 | Let's initialize all this in Private::Private(). Cleaner and less Coverity warnings. | |
564 | can be clone() const | |
573 | Missing copying:
| |
623 | can be clone() const | |
697 | can be clone() const | |
729 | can be clone() const | |
799 | can be clone() const | |
859 | can be clone() const | |
936 | can be clone() const | |
src/common/KReportRenderObjects.h | ||
58 | +title param. | |
63 | While we're looking here. Add docs informing that ownership is transferred. | |
65 | Add docs informing that the page object will be removed and deleted. | |
70 | Add docs informing that ownership is transferred. | |
71 | Setion -> Section | |
71 | Add docs informing that the section object will be removed and deleted. | |
124 | How about keeping X and Y by using Qt::Orientation and removing Sort? | |
133 | +const | |
203 | Not done... | |
245 | let's add arg name | |
248 | let's add arg name | |
251 | let's add arg name | |
271 | let's add arg name | |
274 | let's add arg name | |
326 | let's add arg name | |
346 | let's add arg name | |
349 | let's add arg name | |
352 | let's add arg name |
Almost there just one thing - xLessThan!
src/common/KReportRenderObjects.h | ||
---|---|---|
152–155 | I mean xLessThan |
Yes, i meant to ask a question about that.
What do you mean 'move to cpp'?
Do you mean, it will remain a static method of OROSection, OROSection::Private or just a static function that is not a member of anything?
src/common/KReportRenderObjects.cpp | ||
---|---|---|
23 | Let's have static or use namespace { } |
Having read the differences between static and using a namespace I will use static. Hopefully we can close this later this evening :)
src/plugins/CMakeLists.txt | ||
---|---|---|
1 | Do you remember the reason? |
Yes, it was becuase we un-exported the classes needed by plugins. We can re-enable it, and I will also create a task to create a new barcode plugin based on some other library.