Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
Details
Details
- Reviewers
staniek - Commits
- R14:1b554d8e7547: Improve ORODocument
run kreportexample and ensure rendering as expected
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Branch
- dptr_oro
- Lint
No Linters Available - Unit
No Unit Test Coverage
There are a very large number of changes, so older changes are hidden. Show Older Changes
| src/common/KReportRenderObjects.cpp | ||
|---|---|---|
| 61 | clear is not really needed | |
| 64 | same here | |
| 73 | Second arg not needed | |
| 78 | Second arg not needed, default constructed value is returned here, which for Qt is nullptr. | |
| 89 | Second arg not needed | |
| 94 | Second arg not needed | |
| 135 | For symmetry don't we want to also delete page? | |
| 140 | For symmetry don't we want to also delete section? | |
| 168 | not really needed | |
| 185 | not really needed | |
| 200 | Second arg not needed | |
| 205 | Second arg not needed | |
| 247 | For symmetry don't we want to also delete primitive? | |
| 281 | KReport::recordCount() is qint64 so how about using qint64 here too? | |
| 287 | Let's initialize all members here because it's possible. | |
| 288 | Second arg not needed | |
| 292 | Second arg not needed | |
| 383 | If we add delete to OROPage::removePrimitive() this line won't be correct. Either:
| |
| 448 | Let's initialize all this in Private::Private(). Cleaner and less Coverity warnings. | |
| 451 | TODO: rename to KReportTextStyleData, add initialization of KReportTextStyleData::alignment and KReportTextStyleData::backgroundOpacity. | |
| 540 | can be clone() const | |
| 549 | Missing copying:
| |
| 602 | can be clone() const | |
| 679 | can be clone() const | |
| 714 | can be clone() const | |
| 788 | can be clone() const | |
| 851 | can be clone() const | |
| 932 | can be clone() const | |
| src/common/KReportRenderObjects.h | ||
| 58 | +title param. | |
| 73 | While we're looking here. Add docs informing that ownership is transferred. | |
| 75 | Add docs informing that the page object will be removed and deleted. | |
| 80 | Add docs informing that ownership is transferred. | |
| 81 | Setion -> Section | |
| 81 | Add docs informing that the section object will be removed and deleted. | |
| 120 | How about keeping X and Y by using Qt::Orientation and removing Sort? | |
| 130 | +const | |
| 203 | Not done... | |
| 247 | let's add arg name | |
| 250 | let's add arg name | |
| 253 | let's add arg name | |
| 274 | let's add arg name | |
| 277 | let's add arg name | |
| 331 | let's add arg name | |
| 352 | let's add arg name | |
| 355 | let's add arg name | |
| 358 | let's add arg name | |
Comment Actions
Almost there just one thing - xLessThan!
| src/common/KReportRenderObjects.h | ||
|---|---|---|
| 147 | I mean xLessThan | |
Comment Actions
Yes, i meant to ask a question about that.
What do you mean 'move to cpp'?
Do you mean, it will remain a static method of OROSection, OROSection::Private or just a static function that is not a member of anything?
| src/common/KReportRenderObjects.cpp | ||
|---|---|---|
| 23 | Let's have static or use namespace { } | |
Comment Actions
Having read the differences between static and using a namespace I will use static. Hopefully we can close this later this evening :)
| src/plugins/CMakeLists.txt | ||
|---|---|---|
| 1 ↗ | (On Diff #8795) | Do you remember the reason? |
Comment Actions
Yes, it was becuase we un-exported the classes needed by plugins. We can re-enable it, and I will also create a task to create a new barcode plugin based on some other library.