Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
staniek |
Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
run kreportexample and ensure rendering as expected
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/common/KReportRenderObjects.cpp | ||
---|---|---|
63 | clear is not really needed | |
66 | same here | |
77 | Second arg not needed | |
82 | Second arg not needed, default constructed value is returned here, which for Qt is nullptr. | |
96–101 | Second arg not needed | |
106 | Second arg not needed | |
149 | For symmetry don't we want to also delete page? | |
154 | For symmetry don't we want to also delete section? | |
189 | not really needed | |
205 | not really needed | |
224 | Second arg not needed | |
229 | Second arg not needed | |
273 | For symmetry don't we want to also delete primitive? | |
293 | KReport::recordCount() is qint64 so how about using qint64 here too? | |
299 | Let's initialize all members here because it's possible. | |
327 | Second arg not needed | |
332 | Second arg not needed | |
422 | If we add delete to OROPage::removePrimitive() this line won't be correct. Either:
| |
471 | TODO: rename to KReportTextStyleData, add initialization of KReportTextStyleData::alignment and KReportTextStyleData::backgroundOpacity. | |
485–493 | Let's initialize all this in Private::Private(). Cleaner and less Coverity warnings. | |
559–584 | can be clone() const | |
596 | Missing copying:
| |
646 | can be clone() const | |
720 | can be clone() const | |
752 | can be clone() const | |
822 | can be clone() const | |
877–882 | can be clone() const | |
959 | can be clone() const | |
src/common/KReportRenderObjects.h | ||
56–57 | +title param. | |
60 | While we're looking here. Add docs informing that ownership is transferred. | |
62 | Add docs informing that the page object will be removed and deleted. | |
67 | Add docs informing that ownership is transferred. | |
68 | Setion -> Section | |
68 | Add docs informing that the section object will be removed and deleted. | |
200–201 | How about keeping X and Y by using Qt::Orientation and removing Sort? | |
205 | +const | |
272–273 | Not done... | |
315 | let's add arg name | |
317–318 | let's add arg name | |
320–321 | let's add arg name | |
340–341 | let's add arg name | |
342–343 | let's add arg name | |
395–396 | let's add arg name | |
415–416 | let's add arg name | |
417–418 | let's add arg name | |
418–419 | let's add arg name |
Almost there just one thing - xLessThan!
src/common/KReportRenderObjects.h | ||
---|---|---|
224–225 | I mean xLessThan |
Yes, i meant to ask a question about that.
What do you mean 'move to cpp'?
Do you mean, it will remain a static method of OROSection, OROSection::Private or just a static function that is not a member of anything?
src/common/KReportRenderObjects.cpp | ||
---|---|---|
23 | Let's have static or use namespace { } |
Having read the differences between static and using a namespace I will use static. Hopefully we can close this later this evening :)
src/plugins/CMakeLists.txt | ||
---|---|---|
1 | Do you remember the reason? |
Yes, it was becuase we un-exported the classes needed by plugins. We can re-enable it, and I will also create a task to create a new barcode plugin based on some other library.