Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
staniek |
Port OROPage
Port OROSection
Port and improve OROPrimitive
Port OROTextBox
Port OROLine
Port OROImage
Port OROPicture
Port OPORect and OROEllipse
Port OROCheck
Clone using methods not accessing the d pointer directtly
run kreportexample and ensure rendering as expected
No Linters Available |
No Unit Test Coverage |
src/common/KReportRenderObjects.cpp | ||
---|---|---|
45 | clear is not really needed | |
48 | same here | |
66–71 | Second arg not needed | |
71 | Second arg not needed, default constructed value is returned here, which for Qt is nullptr. | |
90–95 | Second arg not needed | |
100 | Second arg not needed | |
143 | For symmetry don't we want to also delete page? | |
148 | For symmetry don't we want to also delete section? | |
183 | not really needed | |
199 | not really needed | |
218 | Second arg not needed | |
223 | Second arg not needed | |
267 | For symmetry don't we want to also delete primitive? | |
287 | KReport::recordCount() is qint64 so how about using qint64 here too? | |
293 | Let's initialize all members here because it's possible. | |
321 | Second arg not needed | |
326 | Second arg not needed | |
421 | If we add delete to OROPage::removePrimitive() this line won't be correct. Either:
| |
470 | TODO: rename to KReportTextStyleData, add initialization of KReportTextStyleData::alignment and KReportTextStyleData::backgroundOpacity. | |
484–492 | Let's initialize all this in Private::Private(). Cleaner and less Coverity warnings. | |
558–583 | can be clone() const | |
592 | Missing copying:
| |
642 | can be clone() const | |
716 | can be clone() const | |
748 | can be clone() const | |
818 | can be clone() const | |
873–878 | can be clone() const | |
955 | can be clone() const | |
src/common/KReportRenderObjects.h | ||
58 | +title param. | |
63 | While we're looking here. Add docs informing that ownership is transferred. | |
65 | Add docs informing that the page object will be removed and deleted. | |
70 | Add docs informing that ownership is transferred. | |
71 | Setion -> Section | |
71 | Add docs informing that the section object will be removed and deleted. | |
201 | How about keeping X and Y by using Qt::Orientation and removing Sort? | |
210 | +const | |
280 | Not done... | |
322 | let's add arg name | |
324–325 | let's add arg name | |
327–328 | let's add arg name | |
347–348 | let's add arg name | |
350–351 | let's add arg name | |
402–403 | let's add arg name | |
422–423 | let's add arg name | |
425–426 | let's add arg name | |
427–428 | let's add arg name |
Almost there just one thing - xLessThan!
src/common/KReportRenderObjects.h | ||
---|---|---|
229–232 | I mean xLessThan |
Yes, i meant to ask a question about that.
What do you mean 'move to cpp'?
Do you mean, it will remain a static method of OROSection, OROSection::Private or just a static function that is not a member of anything?
src/common/KReportRenderObjects.cpp | ||
---|---|---|
23 | Let's have static or use namespace { } |
Having read the differences between static and using a namespace I will use static. Hopefully we can close this later this evening :)
src/plugins/CMakeLists.txt | ||
---|---|---|
1 | Do you remember the reason? |
Yes, it was becuase we un-exported the classes needed by plugins. We can re-enable it, and I will also create a task to create a new barcode plugin based on some other library.