| davidedmundson | |
| ahiemstra |
| Plasma |
Depending on hardware, Linux kernel exports battery state in
different files. Previously only charge_now, charge_full and current_now
were available in ksysguard. With this commit all are selectable.
While we have now screens with more than 1000 pixels height,
a percentage with 100 steps will show a ladder. This commit also
make the created graphs nicer by giving 1000 steps.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 23873 | |
| Build 23891: arc lint + arc unit |
Good stuff. Just two small comments.
Additionally, you may be interested in https://phabricator.kde.org/D28333 , which will eventually replace ksysguardd and has a better API for sensors.
| ksysguardd/Linux/acpi.c | ||
|---|---|---|
| 82 | These two lines are now repeated in all "registerX" functions. Maybe move this to initAcpiBattery and pass it to each function as a parameter? | |
| 163 | You cast to double but then store it in a float, which implies a cast to float. Probably better to just cast to float directly. (Also applies to the functions below.) | |
| ksysguardd/Linux/acpi.c | ||
|---|---|---|
| 103 | Uhm, this should be const char *name right? I don't really see how this can work otherwise. | |