Update visibility cache when notebook visibility is changed
ClosedPublic

Authored by dcaliste on Mar 4 2020, 10:51 AM.

Details

Summary

incidence visibility is cached in mIncidenceVisibility hash array. But this array is not updated when a notebook visibility is changed when calling updateNotebook().

It also adds a method to inquire the visibility of a notebook. Previously, one can only inquire the visibility of an incidence, while the visibility flag is set for a notebook.

Test Plan

add a test in testmemorycalendar.cpp to demonstrate the issue and the fix.

Diff Detail

Repository
R172 KCalendar Core
Branch
visibility
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23240
Build 23258: arc lint + arc unit
dcaliste created this revision.Mar 4 2020, 10:51 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 4 2020, 10:51 AM
dcaliste requested review of this revision.Mar 4 2020, 10:51 AM
dcaliste edited the summary of this revision. (Show Details)Mar 4 2020, 10:53 AM
dcaliste edited the test plan for this revision. (Show Details)
dcaliste added a subscriber: KDE PIM.
dcaliste updated this revision to Diff 76919.Mar 4 2020, 10:58 AM

Rename mistake in header declaration (incidence -> notebook).

winterz accepted this revision.Mar 5 2020, 2:56 PM
This revision is now accepted and ready to land.Mar 5 2020, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Thanks @winterz for review.