The menu we retun can outlive the manager. So we can't use it or its members in
slots when connecting to signals of the menu or it's actions. This also switches
the actions' data() back to being the schemePaths instead of the rows of the
corresponding indices.
Details
Details
- Reviewers
broulik - Group Reviewers
Frameworks - Commits
- R265:a33675fdb3e4: Don't assume the manager and menu have the same lifetime
Open Labplot which currently triggers this crash.
Diff Detail
Diff Detail
- Repository
- R265 KConfigWidgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/kcolorschememanager.cpp | ||
---|---|---|
197–198 | You can connect to qApp |
src/kcolorschememanager.cpp | ||
---|---|---|
197–198 | What is meant by "connecting to qApp"? Just doing the scheme switching here? I wanted to avoid the duplication that's why I created the static helper method. |
src/kcolorschememanager.cpp | ||
---|---|---|
197–198 | Using qApp as context object |
src/kcolorschememanager.cpp | ||
---|---|---|
197–198 | Thanks! Makes sense! |