Don't assume the manager and menu have the same lifetime

Authored by davidre on Jan 22 2020, 6:45 PM.

Description

Don't assume the manager and menu have the same lifetime

Summary:
The menu we retun can outlive the manager. So we can't use it or its members in
slots when connecting to signals of the menu or it's actions. This also switches
the actions' data() back to being the schemePaths instead of the rows of the
corresponding indices.

Test Plan: Open Labplot which currently triggers this crash.

Reviewers: Frameworks, broulik

Reviewed By: broulik

Subscribers: anthonyfieroni, broulik, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D26848

Details

Committed
davidreJan 29 2020, 2:39 PM
Reviewer
broulik
Differential Revision
D26848: Don't assume the manager and menu have the same lifetime
Parents
R265:e9ca0991da32: [KColorSchemeManager] Don't list duplicates
Branches
Unknown
Tags
Unknown