SVN commit dialog box contains no list of changes that will be commited. This is often confusing.
This commit adds basic changes list for SVN commit action.
Also contains workaround for QTBUG-40584 to preserve dialog sizes, see KWindowConfig::restoreWindowSize() docs.
Details
Details
- Reviewers
elvisangelaccio meven ngraham - Group Reviewers
Dolphin VDG - Commits
- R449:c9e0e2269ffd: Add changes list for SVN commit dialog
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Updated in response to review comments: added Q_ASSERT, added UpdateRequiredVersion because this status is possible.
svn/fileviewsvnplugin.cpp | ||
---|---|---|
382 | We should be really careful with this asserts because there is no place documenting for example "There should be no NormalVersion". One can change beginRetrieval() and because we doesn't have test units for everything this could damage SVN plugin in some rare cases. |
svn/fileviewsvnplugin.cpp | ||
---|---|---|
382 | I am fine with either solution. |
svn/fileviewsvnplugin.cpp | ||
---|---|---|
385 | Can we use some context here ? |