Differential D26179

[KCM/Component] Clean up code of filemanager cfg
ClosedPublic
Actions

Authored by meven on Dec 23 2019, 10:08 AM.

Tags

Subscribers

Details

Reviewers

crossi
ervin

Group Reviewers

Commits

R119:7651c1f42b5e: [KCM/Component] Clean up code of filemanager cfg

Summary

Depends on D26100

Test Plan

kcmshell5 componentchooser

Diff Detail

Repository

R119 Plasma Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20412
Build 20430: arc lint + arc unit

meven requested review of this revision.Dec 23 2019, 10:08 AM

meven created this revision.

Harbormaster completed remote builds in B20191: Diff 72056.Dec 23 2019, 10:08 AM

meven edited the summary of this revision. (Show Details)Dec 23 2019, 10:09 AM

meven added a dependency: D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly.

Add an override in header

Harbormaster completed remote builds in B20193: Diff 72058.Dec 23 2019, 10:24 AM

Add an override in header

Harbormaster completed remote builds in B20194: Diff 72059.Dec 23 2019, 10:25 AM

ervin requested changes to this revision.Dec 23 2019, 1:13 PM

ervin added inline comments.

kcms/componentchooser/componentchooserfilemanager.cpp
71–72	Opening curly brace should be on the same line than for
93	Space before * not after

This revision now requires changes to proceed.Dec 23 2019, 1:13 PM

Formatting issues fix

Harbormaster completed remote builds in B20208: Diff 72090.Dec 23 2019, 3:22 PM

meven marked 2 inline comments as done.Dec 23 2019, 3:23 PM

Fix formatting

Harbormaster completed remote builds in B20210: Diff 72092.Dec 23 2019, 3:35 PM

fix two indentation issues

Harbormaster completed remote builds in B20216: Diff 72102.Dec 23 2019, 5:04 PM

ervin requested changes to this revision.Dec 23 2019, 5:28 PM

ervin added inline comments.

kcms/componentchooser/componentchooserfilemanager.cpp
71–72	Is it me or it's in fact not done? Also should have space before & not after.
93	Is it me or it's not done in fact?

This revision now requires changes to proceed.Dec 23 2019, 5:28 PM

Formatting & indentation

Harbormaster completed remote builds in B20392: Diff 72365.Dec 30 2019, 9:15 AM

meven planned changes to this revision.Dec 30 2019, 9:16 AM

Formatting & indentation

Harbormaster completed remote builds in B20393: Diff 72366.Dec 30 2019, 9:17 AM

Formatting & indentation

Harbormaster completed remote builds in B20394: Diff 72367.Dec 30 2019, 9:18 AM

Remove unrelated changes

Harbormaster completed remote builds in B20395: Diff 72368.Dec 30 2019, 9:22 AM

ervin accepted this revision.Dec 30 2019, 4:52 PM

This revision is now accepted and ready to land.Dec 30 2019, 4:52 PM

cherry-pick on master

Harbormaster completed remote builds in B20412: Diff 72402.Dec 30 2019, 5:23 PM

Closed by commit R119:7651c1f42b5e: [KCM/Component] Clean up code of filemanager cfg (authored by meven). · Explain WhyDec 30 2019, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcms/componentchooser/componentchooserfilemanager.h (2 lines)
M			kcms/componentchooser/componentchooserfilemanager.cpp (38 lines)

Diff 72402

kcms/componentchooser/componentchooserfilemanager.h

Loading...

kcms/componentchooser/componentchooserfilemanager.cpp

Loading...