[KCM/Component] Clean up code of filemanager cfg
ClosedPublic

Authored by meven on Dec 23 2019, 10:08 AM.

Details

Summary

Depends on D26100

Test Plan

kcmshell5 componentchooser

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D26179_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20208
Build 20226: arc lint + arc unit
meven requested review of this revision.Dec 23 2019, 10:08 AM
meven created this revision.
meven updated this revision to Diff 72058.Dec 23 2019, 10:24 AM

Add an override in header

meven updated this revision to Diff 72059.Dec 23 2019, 10:25 AM

Add an override in header

ervin requested changes to this revision.Dec 23 2019, 1:13 PM
ervin added inline comments.
kcms/componentchooser/componentchooserfilemanager.cpp
71–72

Opening curly brace should be on the same line than for

93

Space before * not after

This revision now requires changes to proceed.Dec 23 2019, 1:13 PM
meven updated this revision to Diff 72090.Dec 23 2019, 3:22 PM

Formatting issues fix

meven marked 2 inline comments as done.Dec 23 2019, 3:23 PM
meven updated this revision to Diff 72092.Dec 23 2019, 3:35 PM

Fix formatting

meven updated this revision to Diff 72102.Dec 23 2019, 5:04 PM

fix two indentation issues

ervin requested changes to this revision.Dec 23 2019, 5:28 PM
ervin added inline comments.
kcms/componentchooser/componentchooserfilemanager.cpp
71–72

Is it me or it's in fact not done? Also should have space before & not after.

93

Is it me or it's not done in fact?

This revision now requires changes to proceed.Dec 23 2019, 5:28 PM
meven updated this revision to Diff 72365.Dec 30 2019, 9:15 AM
meven marked 2 inline comments as done.

Formatting & indentation

meven planned changes to this revision.Dec 30 2019, 9:16 AM
meven updated this revision to Diff 72366.Dec 30 2019, 9:17 AM

Formatting & indentation

meven updated this revision to Diff 72367.Dec 30 2019, 9:18 AM

Formatting & indentation

meven updated this revision to Diff 72368.Dec 30 2019, 9:22 AM

Remove unrelated changes

ervin accepted this revision.Dec 30 2019, 4:52 PM
This revision is now accepted and ready to land.Dec 30 2019, 4:52 PM
meven updated this revision to Diff 72402.Dec 30 2019, 5:23 PM

cherry-pick on master

This revision was automatically updated to reflect the committed changes.