Replace custom dialog with QQC2 Dialog
Details
Details
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Branch
- gemini-dialog
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20309 Build 20327: arc lint + arc unit
Comment Actions
That's looking pretty good, really :) Also code reduction is certainly good ;)
gemini/qml/components/Dialog.qml | ||
---|---|---|
135–137 | Thinking this wants to be centered... or if that means things end up looking lop-sided, perhaps have it right-aligned? As it stands, it looks kind of... very heavy on the left hand side. |
Comment Actions
Probably want to update the screenshot (for posterity), but... otherwise yup, go for it :)