Differential D26221

Use QQC2 Dialog
ClosedPublic
Actions

Authored by ognarb on Dec 25 2019, 4:32 PM.

Details

Reviewers
leinir
Group Reviewers
Calligra: 3.0
Commits
R8:d6cdb21118b2: Use QQC2 Dialog
Summary

Replace custom dialog with QQC2 Dialog

Test Plan

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Dec 25 2019, 4:32 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptDec 25 2019, 4:32 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
ognarb requested review of this revision.Dec 25 2019, 4:32 PM
ognarb updated this revision to Diff 72174.Dec 25 2019, 5:18 PM

Update look

ognarb edited the test plan for this revision. (Show Details)Dec 25 2019, 5:18 PM
leinir added a comment.Dec 26 2019, 2:22 PM

That's looking pretty good, really :) Also code reduction is certainly good ;)

gemini/qml/components/Dialog.qml
135–137

Thinking this wants to be centered... or if that means things end up looking lop-sided, perhaps have it right-aligned? As it stands, it looks kind of... very heavy on the left hand side.

ognarb updated this revision to Diff 72240.Dec 27 2019, 10:39 AM
  • Center the loading animation
ognarb marked an inline comment as done.Dec 27 2019, 11:18 AM
leinir accepted this revision.Mar 9 2020, 9:35 AM
In D26221#583471, @ognarb wrote:
  • Center the loading animation

Probably want to update the screenshot (for posterity), but... otherwise yup, go for it :)

This revision is now accepted and ready to land.Mar 9 2020, 9:35 AM
Closed by commit R8:d6cdb21118b2: Use QQC2 Dialog (authored by ognarb). · Explain WhyMar 9 2020, 5:34 PM
This revision was automatically updated to reflect the committed changes.
ognarb edited the test plan for this revision. (Show Details)Mar 9 2020, 6:20 PM

Revision Contents
Changeset List

PathPackages
Mgemini/qml/components/Dialog.qml (174 lines)

Diff 77299

View Options

gemini/qml/components/Dialog.qml

Loading...