Do not duplicate captive portal notifications and close them when we are no longer
behind captive portal.
BUG: 411846
BUG: 411847
ngraham | |
broulik |
Plasma |
Do not duplicate captive portal notifications and close them when we are no longer
behind captive portal.
BUG: 411846
BUG: 411847
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Being in an airport right now myself (as is Harald, I imagine), I'm able to test this immediately. :) Works great, shipit, and sorry for introducing this regression when I made the notification persistent. I keep forgetting that its lifecycle needs to be managed in this case.
Due to a confusing design notification objects can delete themselves.
If the network changes after the notification is externally closed this will crash.
kded/portalmonitor.h | ||
---|---|---|
42 | Needs to be QPointer |