Differential D26042

Captive portal notification improvements
ClosedPublic
Actions

Authored by jgrulich on Dec 16 2019, 10:15 AM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Plasma
Commits
R116:1ffef126b8f0: Captive portal notification improvements
Summary

Do not duplicate captive portal notifications and close them when we are no longer
behind captive portal.

BUG: 411846
BUG: 411847

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Dec 16 2019, 10:15 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 10:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Dec 16 2019, 10:15 AM
jgrulich edited the summary of this revision. (Show Details)Dec 16 2019, 10:15 AM
jgrulich added a reviewer: Plasma.
jgrulich updated this revision to Diff 71660.Dec 16 2019, 10:19 AM

: - Notification might be already closed

ngraham accepted this revision.Dec 16 2019, 10:46 PM

Being in an airport right now myself (as is Harald, I imagine), I'm able to test this immediately. :) Works great, shipit, and sorry for introducing this regression when I made the notification persistent. I keep forgetting that its lifecycle needs to be managed in this case.

This revision is now accepted and ready to land.Dec 16 2019, 10:46 PM
Closed by commit R116:1ffef126b8f0: Captive portal notification improvements (authored by jgrulich). · Explain WhyDec 17 2019, 9:47 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a subscriber: davidedmundson.Dec 17 2019, 10:39 AM

Due to a confusing design notification objects can delete themselves.

If the network changes after the notification is externally closed this will crash.

kded/portalmonitor.h
42

Needs to be QPointer

jgrulich marked an inline comment as done.Dec 17 2019, 10:54 AM

Revision Contents
Changeset List

PathPackages
Mkded/portalmonitor.h (4 lines)
Mkded/portalmonitor.cpp (45 lines)

Diff 71706

View Options

kded/portalmonitor.h

Loading...
View Options

kded/portalmonitor.cpp

Loading...