BUG: 412976
Here were some old layout code to set the sizes of ComboBoxes. I simply removed them.
ngraham |
Plasma |
BUG: 412976
Here were some old layout code to set the sizes of ComboBoxes. I simply removed them.
Open Lock Screen KCM. Change wallpaper type to Picture of The Day. Check the ComboBox of POTD.
No Linters Available |
No Unit Test Coverage |
Buildable 18905 | |
Build 18923: arc lint + arc unit |
I can confirm the bug and that this fixes it.
However, you're porting to use the QQC2 Combobox even though https://bugs.kde.org/show_bug.cgi?id=403153 isn't fixed yet. As a result, the pop-up looks like this a lot of the time:
I think we'll need to redouble our efforts to fix that bug, or else work around it by setting a minimum width on the combobox here (not ideal, but maybe better than nothing?)
+1 for simplifying the strings, but keep in mind that any change that alters strings, can't be a bugfix on the stable branch and needs to be master-only.
Might be better to only made the code changes on the stable branch, and do the string changes in a separate patch bound for master only.
Yep, now you just need to merge Plasma/5.17 into master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 for the full set of recommended instructions for landing a change on the stable branch