Fix POTD config ComboBox display issue in Lock Screen KCM
ClosedPublic

Authored by guoyunhe on Nov 17 2019, 2:03 PM.

Details

Summary

BUG: 412976

Here were some old layout code to set the sizes of ComboBoxes. I simply removed them.

Test Plan

Open Lock Screen KCM. Change wallpaper type to Picture of The Day. Check the ComboBox of POTD.

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18874
Build 18892: arc lint + arc unit
guoyunhe created this revision.Nov 17 2019, 2:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 17 2019, 2:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Nov 17 2019, 2:03 PM
guoyunhe edited the summary of this revision. (Show Details)Nov 17 2019, 2:04 PM
guoyunhe added a reviewer: Plasma.
guoyunhe edited the summary of this revision. (Show Details)

I can confirm the bug and that this fixes it.

However, you're porting to use the QQC2 Combobox even though https://bugs.kde.org/show_bug.cgi?id=403153 isn't fixed yet. As a result, the pop-up looks like this a lot of the time:

I think we'll need to redouble our efforts to fix that bug, or else work around it by setting a minimum width on the combobox here (not ideal, but maybe better than nothing?)

guoyunhe added a comment.EditedNov 18 2019, 12:58 PM

Another approach is to shorten the texts:

guoyunhe updated this revision to Diff 69922.Nov 18 2019, 1:09 PM
guoyunhe edited the summary of this revision. (Show Details)

Shorten POTD provider names and remove descriptions that are never used anywhere.

+1 for simplifying the strings, but keep in mind that any change that alters strings, can't be a bugfix on the stable branch and needs to be master-only.

Might be better to only made the code changes on the stable branch, and do the string changes in a separate patch bound for master only.

guoyunhe updated this revision to Diff 69929.Nov 18 2019, 3:24 PM

Move string changes to another patch

ngraham accepted this revision.Nov 18 2019, 4:21 PM

5.17 branch please.

This revision is now accepted and ready to land.Nov 18 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.

5.17 branch please.

Not sure if I did it correctly...

ngraham added a comment.EditedNov 18 2019, 4:50 PM

Yep, now you just need to merge Plasma/5.17 into master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 for the full set of recommended instructions for landing a change on the stable branch