Shorten POTD provider names and remove description that is not used anywhere
ClosedPublic

Authored by guoyunhe on Mon, Nov 18, 3:21 PM.

Details

Summary

QtQuick Controls 2 ComboBox doesn't handle long option well. Short names can solve the issue of D25354.

The ComboBox is the only place that the names are used. The "Description"s aren't used anywhere and they are mostly the repeat of "Name"s. So I removed "Description" field.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Mon, Nov 18, 3:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Nov 18, 3:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Mon, Nov 18, 3:21 PM
guoyunhe edited the summary of this revision. (Show Details)

For changed strings, you don't need to remove the existing translations; just change the English strings.

For removed strings, it's fine to remove everything.

guoyunhe updated this revision to Diff 69930.Mon, Nov 18, 3:49 PM

Keep old translations

Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings?

guoyunhe edited the summary of this revision. (Show Details)Mon, Nov 18, 3:54 PM

Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings?

Added.

ngraham requested changes to this revision.Mon, Nov 18, 3:57 PM
ngraham added inline comments.
dataengines/potd/noaaprovider.json
4

Weaher -> Weather

This revision now requires changes to proceed.Mon, Nov 18, 3:57 PM
ngraham accepted this revision.Mon, Nov 18, 3:58 PM

LGTM

This revision is now accepted and ready to land.Mon, Nov 18, 3:58 PM
This revision was automatically updated to reflect the committed changes.

How about we fix the size or the combo instead?

I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153

I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153

Then don't port things before it's fixed. It's a blocker for a reason.

I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153

Then don't port things before it's fixed. It's a blocker for a reason.

In this case we had to port to fix an even worse bug. See D25354.