Details
Diff Detail
- Repository
- R7 Konversation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
After accepting, Nate added a blocking reviewer. If you check the logs in this review, the code landed without being accepted.
Maybe in such scenarios the review should not be accepted immediately.
I'd suggest reverting it and reopening the review.
Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer. I have reverted this change. Here ba083b9983c19b13999a9733f7c1ec64c5347c8f
Heh, no' it's the opposite. :) It means, "Do not land this patch without that person's approval." arc even warns you of this when you try to run arc land with a blocking reviewer who has not accepted yet.
It's basically a way of saying "looks good to me but please wait for such-and-such person's approval before landing the patch", but saying this with process rather than words.