Rename action name to make it consistent with other applications
Needs ReviewPublic

Authored by shubham on Tue, Sep 10, 2:29 PM.

Diff Detail

Repository
R7 Konversation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Tue, Sep 10, 2:29 PM
Restricted Application added a project: Documentation. · View Herald TranscriptTue, Sep 10, 2:29 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
shubham requested review of this revision.Tue, Sep 10, 2:29 PM
shubham retitled this revision from Summary: Rename action name to make it consistent with other applications to Rename action name to make it consistent with other applications.Tue, Sep 10, 2:30 PM
shubham added reviewers: hein, ngraham.
ngraham accepted this revision.Tue, Sep 10, 7:42 PM
ngraham added 1 blocking reviewer(s): hein.
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 11, 9:13 AM
This revision was automatically updated to reflect the committed changes.

Wasn't this landed a bit too early?

I saw green flag so went for it. You have any suggestions/queries?

After accepting, Nate added a blocking reviewer. If you check the logs in this review, the code landed without being accepted.
Maybe in such scenarios the review should not be accepted immediately.

I'd suggest reverting it and reopening the review.

shubham reopened this revision.EditedWed, Sep 11, 9:43 AM

Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer. I have reverted this change. Here ba083b9983c19b13999a9733f7c1ec64c5347c8f

Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer

Heh, no' it's the opposite. :) It means, "Do not land this patch without that person's approval." arc even warns you of this when you try to run arc land with a blocking reviewer who has not accepted yet.

It's basically a way of saying "looks good to me but please wait for such-and-such person's approval before landing the patch", but saying this with process rather than words.