This patch fixes a link failure when building with the LLVM toolchain which does not discover the dependency on or pull in the private dolphin library when linking dolphin itself.
BUG: 410237
elvisangelaccio |
This patch fixes a link failure when building with the LLVM toolchain which does not discover the dependency on or pull in the private dolphin library when linking dolphin itself.
BUG: 410237
Lint Skipped |
Unit Tests Skipped |
Buildable 14527 | |
Build 14545: arc lint + arc unit |
Can you try to build another kdeinit app (i.e. khelpcenter) to check if you get the same error?
src/CMakeLists.txt | ||
---|---|---|
304 | Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin? |
Can you try to build another kdeinit app (i.e. `khelpcenter`) to check if you get the same error?
No. But khelpcentre doesn't use a static library.
Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin?
No, should I?
Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin?
Appears that this works too:
target_link_libraries(kdeinit_dolphin PUBLIC dolphinprivate PRIVATE dolphinstatic KF5::Crash )
ping @rjvbb
Do you want someone else to commit this patch or do you want to do it yourself https://community.kde.org/Infrastructure/Phabricator ?
Apologies, I've been stretched way too thin since about the time this diff was accepted, I don't think I even noticed the fact.