Differential D22586

KRun QML proxy: fix path/URL confusion
ClosedPublic
Actions

Authored by dfaure on Jul 20 2019, 2:41 PM.

Details

Reviewers
davidedmundson
apol
Commits
R296:52b1133c3dcd: KRun QML proxy: fix path/URL confusion
Summary

I'm assuming the QString argument is always a complete URL.
The only two users of this code are in extragear/base/plasma-mobile and
they pass something called url.

Test Plan

Not tested, other than building.

Diff Detail

Repository
R296 KDeclarative
Branch
D22586
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14182
Build 14200: arc lint + arc unit
dfaure created this revision.Jul 20 2019, 2:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 20 2019, 2:41 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript
dfaure requested review of this revision.Jul 20 2019, 2:41 PM
apol added a subscriber: apol.Jul 20 2019, 5:52 PM

LGTM other than that.

src/qmlcontrols/kioplugin/krunproxy.cpp
35–36

would it make sense to use db.mimeTypeForUrl?

dfaure updated this revision to Diff 62138.Jul 20 2019, 5:57 PM

You'd think I would remember my own APIs.... :-)

apol added a comment.Jul 21 2019, 9:05 AM
In D22586#498715, @dfaure wrote:

You'd think I would remember my own APIs.... :-)

;-)

apol accepted this revision.Jul 22 2019, 10:17 PM
This revision is now accepted and ready to land.Jul 22 2019, 10:17 PM
Closed by commit R296:52b1133c3dcd: KRun QML proxy: fix path/URL confusion (authored by dfaure). · Explain WhyJul 23 2019, 8:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62138

View Options

src/qmlcontrols/kioplugin/krunproxy.h

Loading...
View Options

src/qmlcontrols/kioplugin/krunproxy.cpp

Loading...