The Breeze SDDM theme now shows a logo that can be configured by distro vendors or curious users or anyone else.
Details
- Reviewers
filipf ngraham - Group Reviewers
VDG Plasma - Commits
- R120:7a7363289304: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen
Test configuration and defaults.
Default logo:
Example with a distro logo:
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- distro-logo-slot (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13942 Build 13960: arc lint + arc unit
This is why you shouldn't forget to test - default logo is now no longer pitifully small
An interesting idea. Are you in contact with any distros that have requested this or would make use of it?
I wouldn't mind adding some text to the default logo so for any distros that opt to turn it on and not override the defaults, people learn what it actually is (Plasma's logo recognition is low right now). Then again that means unlocalized text, unless you do something clever to allow the logo component to pull text from a localizable file.
This was created directly because an LCP (artwork dude) at openSUSE requested it (see VDG chat).
Names in logos tend not to be localized from roman characters -> other character sets, so this really isn't a large concern for me.
Idea makes sense.
lets drop the word "distro" and then we can use it for corporation/city/whatever logos
sddm-theme/Main.qml | ||
---|---|---|
423 | OpacityAnimator is better where possible |
sddm-theme/Main.qml | ||
---|---|---|
414 | the config object exposes true as "true", not true, so ¯\_(ツ)_/¯ |
sddm-theme/Main.qml | ||
---|---|---|
415 | I haven't a clue what I should set sourceSize to ¯\_(ツ)_/¯ |
sddm-theme/Main.qml | ||
---|---|---|
415 | to the height and width of the item I believe, at least that's what I did here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54 |
sddm-theme/Main.qml | ||
---|---|---|
415 | I don't really have a defined width, but I guess I could define the height |
sddm-theme/Main.qml | ||
---|---|---|
415 | You'll notice that in my example I didn't have height defined, but the sourceSize code should still work because the fillMode magic does set some definitive width. |
I'm testing this out now and there seems to be only one obstacle left, see inline comment
sddm-theme/Main.qml | ||
---|---|---|
424 | units.gridUnit is larger than units.largeSpacing, you can't keep 8 as the multiplier: |
please don't make this
it look not good
we can make it more smaller and put it on any corner
Logo size still looks too big to me; IMO these things shouldn't be too much in the users' face and the logo shouldn't overpower the clock. Also I think the second screenshot doesn't accurately represent new code.
You had units.largeSpacing * 8 before => 8 * 8 = 64
Now it's units.gridUnits * 6 => 18 * 6 = 108
Ideally we'd multiply units.gridUnits with 3 or 4 to get to 64 again (or do Math.round when multiplying with 3.5).
For me units.gridUnits * 3 looks perfect:
And it seems I didn't give the best of advice for sourceSize.width as there's now a binding loop. If width is changed with implicitWidth it goes away though.
On a more general note, I'd keep the logo turned off by default but let's see what others think. Looking into the future it would also be good to add a UI option and chooser too, but not important now.
Yeah, I woudn't actually mind showing the Plasma logo and text there by default at some point as long as it's small and tasteful. Our branding is pretty weak right now and any improvement there is welcome IMO.
But yeah, that's a discussion for later.
As far as I'm concerned the patch is landable; I really like that it's developed into a more generic placeholder rather than one just for distro logos. Nice work @cblack, make sure to edit the commit title and message to reflect this though.
Some things to still consider in the near or more distant future:
- present to distros (namely openSUSE) and see if this is what they wanted
- see if we want this on by default
- add a UI option for having a logo and then an image chooser
- see if the drop shadow will be interfering with existing drop shadows in logos (but logo authors can just remove it themselves I guess)
- move the default svg to the artwork subfolder since it feels like it belongs there
- fix the binding loop related to sourceSize.width
sddm-theme/Main.qml | ||
---|---|---|
421 | try implicitWidth to avoid binding loop |
sddm-theme/Main.qml | ||
---|---|---|
421 | Just remove sourceSize.width We dont define a width. |
sddm-theme/theme.conf.cmake | ||
---|---|---|
2 | I thought this was going to be off by default for now? |
Doesn't really matter to me ¯\_(ツ)_/¯
If other people want it off by default, I'll update the default theme.conf
edit: brainfart - forgot how to reply to inline comments. whoops.
All right, let's try having it on by default for now and see if we hate it during the time before 5.17 branches. If so, we can always turn it off before then.
Plasma folks?